CLN: simplify _setitem_with_indexer

[jbrockmendel]

The MultiIndex check it is doing is unnecessary for positional indexing.

Other things being cleaned up here appear to be remnants from Panel

[jorisvandenbossche]

Now you have been working with _setitem_with_indexer, could you add a docstring for it explaining what the scope of this function is (eg only used for positional indexing?)

[jbrockmendel]

could you add a docstring for it explaining what the scope of this function is (

good idea

[jbrockmendel]

im of mixed mind on adding a docstring at the moment, because there is a big gap between what the method does vs what it is supposed to do.

[jorisvandenbossche]

Even trying to write down a bit what you know about what it is supposed to do and what it actually does (what led you to previous comment) is useful IMO; it doesn't need to be a perfectly standard formatted docstring

[jreback]

lgtm needs a rebase

[jbrockmendel]

rebased+green

[jbrockmendel]

@jorisvandenbossche gentle ping

[jorisvandenbossche]

Thanks!