CLN: move _na_value to DatetimeIndexOpsMixin #13997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Current coverage is 85.28% (diff: 100%)@@ master #13997 diff @@
==========================================
Files 139 139
Lines 50214 50211 -3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 42822 42820 -2
+ Misses 7392 7391 -1
Partials 0 0
|
sinhrks
force-pushed
the
period_na_value
branch
from
432ded4 to
41268c3
Compare
|
@sinhrks Looks good. Can be merged? |
|
lgtm. go ahead @jorisvandenbossche |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffBecause
PeriodIndexnow shares the sameNaTrepr (#13609), can use the same definition onDatetimeIndexOpsMixin