API: Change Period('NAT') to return NaT #13609
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Missing-data
|
CC @MaximilianR |
sinhrks
changed the title
Current coverage is 84.38%@@ master #13609 diff @@
==========================================
Files 142 142
Lines 51225 51225
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43225 43224 -1
- Misses 8000 8001 +1
Partials 0 0
|
| ``Period('NaT')`` now returns ``pd.NaT`` | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Previously, ``Period`` has its own ``Periond('NaT')`` representation different from ``pd.NaT``. Now ``Period('NaT')`` has been changed to return ``pd.NaT``. (:issue:`12759`) |
|
@sinhrks Can you rebase this? Then it will be easier to review the additional changes (as I think the first commit is now already in master?) |
sinhrks
force-pushed
the
period_nat
branch
2 times, most recently
from
0937517 to
3aff2be
Compare
|
@jorisvandenbossche sure. rebased. |
|
thanks @sinhrks this is really nice! |
4 tasks
4 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffpd.Period('NaT', freq='D')now returnspd.NaTrather than its own nat repr.Periodarithmetic,pd.NaTnow supports addition / subtraction withint(previouslyValueError).Added tests for following:
PeriodandPeriodIndex,SeriesopsPeriodIndexcreation from list-like which containsPeriodandNaT(ENH: PeriodIndex now accepts pd.NaT #13430)PeriodIndexboxing.to_period__contains__any NaT-like(pd.NaT, None, float('nan'), np.nan)