Sort IAM role assignments with groups first, then by name #1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
changed the title
david-crespo
commented
Oct 18, 2022
| apiQueryClient.prefetchQuery('policyView', {}), | ||
| // used to resolve user names | ||
| apiQueryClient.prefetchQuery('userList', {}), | ||
| apiQueryClient.prefetchQuery('groupList', {}), |
There was a problem hiding this comment.
This is exactly the kind of bug I was concerned about in #1232
zephraph
reviewed
Oct 18, 2022
| apiQueryClient.prefetchQuery('projectPolicyView', { orgName, projectName }), | ||
| // used to resolve user names | ||
| apiQueryClient.prefetchQuery('userList', {}), | ||
| apiQueryClient.prefetchQuery('groupList', {}), |
There was a problem hiding this comment.
I think this very much re-enforces the fact that this should only be a short term impl.
zephraph
force-pushed
the
fix-iam-sort-bug
branch
from
1610074 to
3b5265c
Compare
zephraph
force-pushed
the
fix-iam-sort-bug
branch
from
3b5265c to
0d37bee
Compare
|
The Omicron commit I upgraded to is not merged yet, it's the latest commit on oxidecomputer/omicron#1830. Even if that PR changes further, the API spec probably won't. In any case I will wait until that's merged, then update this to point to omicron main, then merge. |
# Conflicts: # libs/api/__generated__/Api.ts # libs/api/__generated__/msw-handlers.ts # libs/api/__generated__/validate.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1221
Closes #1235