Ensure transforms are only applied to top level components #1133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1095 there was an issue with the
displayNameplugin where something likewas converted to
There's a few issues here. One obvious issue is that the plugin is never supposed to add
displayNameto something not top level. That's the bit this PR fixes (which resolves the underlying issue even though it doesn't address the actual root).The other issue here is that
dateTimeRangePickershould've never be given a displayName to begin with. The shape is all wrong. This is happening because it finds the function and looks up the tree to see if there's a parent declaration and proceeds to add the display name... this behavior is wrong and was left broadly because it made it easier to solve for theforwardRefcase. I'll create a follow up to solve that one.