Add annotation reader cache and fix doctrine typeGuesser #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update AnnotationParser.php Update AnnotationParser.php
Vincz
previously approved these changes
Jun 23, 2021
mcg-web
reviewed
Jun 23, 2021
docs/annotations/index.md
Outdated
| @@ -13,7 +15,7 @@ overblog_graphql: | |||
| dir: "%kernel.project_dir%/src/GraphQL" | |||
| suffix: ~ | |||
| ``` | |||
|
|
|||
| To use annoation, you must instal ' '' ' and use the annatotton mapping type | |||
composer.json
Outdated
| @@ -3,7 +3,10 @@ | |||
| "type": "symfony-bundle", | |||
| "license": "MIT", | |||
| "description": "This bundle provides tools to build a GraphQL server in your Symfony App.", | |||
| "keywords": ["GraphQL", "Relay"], | |||
| "keywords": [ | |||
There was a problem hiding this comment.
revert all changes on this file please.
| // @codeCoverageIgnoreEnd | ||
| } | ||
| if (!class_exists(ApcuAdapter::class)) { | ||
| // @codeCoverageIgnoreStart |
There was a problem hiding this comment.
we ignore a lot of code here can we add tests to cover these intead ?
Vincz
approved these changes
Jul 28, 2021
mcg-web
requested changes
Sep 22, 2021
Merged
mcg-web
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an cache for annotations reader to improve performances.
And fix doctrine typeGuesser with doctrine 2.9