Fix ci builds #879
Merged
Fix ci builds #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcg-web
commented
Sep 22, 2021
mcg-web
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| Documented? | no |
| Fixed tickets | none |
| License | MIT |
Bump ci ubuntu version to fix setup-php build
|
@Vincz seem like annotations parser tests failed, can you have a look on this please? |
|
Hey @mcg-web :-) The problem comes from an update from Doctrine. It used to set the column type to string by default in the parsing. Now it's done later. To solve this, change this line: by: $type = $this->resolveTypeFromDoctrineType($columnAnnotation->type ?: 'string'); The problem has been solved in PR #867. Do you want me to open a PR on your repo ? |
|
Can you submit a PR to 0.12 with this fix please ? |
mcg-web
force-pushed
the
fix-ci-builds
branch
from
e5aa7c4 to
a524634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.