Refactor TypeBuilder and resolve some todos

.php_cs.dist

@@ -17,6 +17,7 @@ return PhpCsFixer\Config::create()
             'phpdoc_to_comment' => false,
             'no_superfluous_phpdoc_tags' => ['allow_mixed' => true],
             'global_namespace_import' => ['import_functions' => true, 'import_classes' => true, 'import_constants' => true],
+            'phpdoc_summary' => false,
         ]
     )
     ->setFinder($finder)

src/Error/InvalidArgumentError.php

@@ -13,8 +13,13 @@ class InvalidArgumentError extends GraphQLUserError
     private string $name;
     private ConstraintViolationListInterface $errors;
 
-    public function __construct(string $name, ConstraintViolationListInterface $errors, $message = '', $code = 0, Exception $previous = null)
-    {
+    public function __construct(
+        string $name,
+        ConstraintViolationListInterface $errors,
+        string $message = '',
+        int $code = 0,
+        Exception $previous = null
+    ) {
         $this->name = $name;
         $this->errors = $errors;
         parent::__construct($message, $code, $previous);

src/Error/InvalidArgumentsError.php

@@ -12,8 +12,12 @@ class InvalidArgumentsError extends GraphQLUserError
     /** @var InvalidArgumentError[] */
     private array $errors;
 
-    public function __construct(array $errors, $message = '', $code = 0, Exception $previous = null)
-    {
+    public function __construct(
+        array $errors,
+        string $message = '',
+        int $code = 0,
+        Exception $previous = null
+    ) {
         $this->errors = $errors;
         parent::__construct($message, $code, $previous);
     }

src/Error/UserErrors.php

@@ -16,8 +16,12 @@ class UserErrors extends RuntimeException
     /** @var UserError[] */
     private array $errors = [];
 
-    public function __construct(array $errors, $message = '', $code = 0, Exception $previous = null)
-    {
+    public function __construct(
+        array $errors,
+        string $message = '',
+        int $code = 0,
+        Exception $previous = null
+    ) {
         $this->setErrors($errors);
         parent::__construct($message, $code, $previous);
     }

src/ExpressionLanguage/ExpressionFunction/Security/Helper.php

@@ -11,7 +11,7 @@
 use function is_object;
 
 /**
- * @deprecated since 0.13 will be remove in 0.14
+ * @deprecated since 0.13 will be remove in 1.0
  * @codeCoverageIgnore
  */
 final class Helper

src/ExpressionLanguage/ExpressionLanguage.php

@@ -44,8 +44,8 @@ public function compile($expression, $names = [])
      * Argument can be either an Expression object or a string with or
      * without a prefix
      *
-     * @param string            $name       - Name of the searched variable
-     * @param string|Expression $expression - Expression to search in
+     * @param string            $name       - name of the searched variable (needle)
+     * @param string|Expression $expression - expression to search in (haystack)
      *
      * @throws SyntaxError
      */
@@ -78,6 +78,20 @@ public static function expressionContainsVar(string $name, $expression): bool
         return $contained ?? false;
     }
 
+    /**
+     * Checks if value is a string and has the expression trigger prefix.
+     *
+     * @param mixed $value
+     */
+    public static function isStringWithTrigger($value): bool
+    {
+        if (is_string($value)) {
+            return self::stringHasTrigger($value);
+        }
+
+        return false;
+    }
+
     /**
      * Checks if a string has the expression trigger prefix.
      */

src/Generator/Converter/ExpressionConverter.php

@@ -6,7 +6,6 @@
 
 use Murtukov\PHPCodeGenerator\ConverterInterface;
 use Overblog\GraphQLBundle\ExpressionLanguage\ExpressionLanguage;
-use function is_string;
 
 class ExpressionConverter implements ConverterInterface
 {
@@ -35,10 +34,6 @@ public function convert($value)
      */
     public function check($maybeExpression): bool
     {
-        if (is_string($maybeExpression)) {
-            return ExpressionLanguage::stringHasTrigger($maybeExpression);
-        }
-
-        return false;
+        return ExpressionLanguage::isStringWithTrigger($maybeExpression);
     }
 }