Skip to content

Refactor TypeBuilder and resolve some todos #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 2, 2020
Merged

Refactor TypeBuilder and resolve some todos #770

merged 5 commits into from
Nov 2, 2020

Conversation

murtukov
Copy link
Contributor

@murtukov murtukov commented Oct 30, 2020 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
  • Add extended PHPDocs with code examples to each method of TypeBuilder
  • Disable PHP-CS-Fixer rule to add unnecessary dots (they were added even after :
  • Create static method ExpressionLanguage::isStringWithTrigger
  • Other minor changes

@murtukov
Refactor TypeBuilder and resolve some todos
f870649 
- Add extended PHPDocs with code examples
- Disable PHP-CS-Fixer rule to add unnecessary dots
- Create static method to check expression prefix
@murtukov murtukov requested a review from mcg-web October 30, 2020 19:50
@murtukov murtukov requested review from a team, akomm, mavimo and Vincz October 31, 2020 13:21
akomm
akomm reviewed Nov 2, 2020
View reviewed changes
@murtukov murtukov merged commit 55c14a3 into overblog:master Nov 2, 2020
@murtukov murtukov deleted the refactor/type_builder branch November 2, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akomm akomm akomm left review comments

@mcg-web mcg-web mcg-web approved these changes

@mavimo mavimo Awaiting requested review from mavimo

@Vincz Vincz Awaiting requested review from Vincz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murtukov @mcg-web @akomm