-
Couldn't load subscription status.
- Fork 30
refactor: log relative paths for file #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
|
I will come back to this when my OCA is approved. |
|
@algomaster99 Thanks for the update. Please feel free to take your time. As for this PR, there are multiples places where we log absolute paths apart from the places you have fixed, I wonder if you are going to address them too in this PR ? For example:
If our plan is to address all location of this issue, I would recommend searching |
|
Thank you for signing the OCA. |
I was planning to remove harcoded paths everywhere, but I didn't exactly know how to proceed. Ctrl + F over VSCode was the best option. But I will give your idea a spin. Seems better :) Thanks! |
|
Closing this PR as @behnazh-w says that the CI run button has disappeared. |

The paths currently logged in the STDOUT are absolute. For example, if you run
./run_macaron.sh find-source -purl pkg:maven/fr.inria.gforge.spoon/[email protected], it logs the paths where the results are written to:However, these absolute paths exist only inside the docker container that
run_macaronspawns and not on the host machine. To get valid paths for container and host machine, it is better to output relative paths which means stripping/home/macaronfrom it. Thus, I wrap paths in some places withos.path.relpath(path, os.getcwd()). I assume thatWORKDIRinside docker is set toMACARON_WORKSPACE. I have only tested my changes against the local build only.Note that this is not much of an issue if someone runs
macaronwithout using the container.