refactor: log relative paths for file #1028
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paths currently logged in the STDOUT are absolute. For example, if you run
./run_macaron.sh find-source -purl pkg:maven/fr.inria.gforge.spoon/[email protected], it logs the paths where the results are written to:However, these absolute paths exist only inside the docker container that
run_macaronspawns and not on the host machine. To get valid paths for container and host machine, it is better to output relative paths which means stripping/home/macaronfrom it. Thus, I wrap paths in some places withos.path.relpath(path, os.getcwd()). I assume thatWORKDIRinside docker is set toMACARON_WORKSPACE. I have only tested my changes against the local build only.Note that this is not much of an issue if someone runs
macaronwithout using the container.