[GR-30765] Extend Native Image diagnostic output. #3515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graalvmbot
force-pushed
the
github/chaeubl/GR-30765
branch
4 times, most recently
from
f4e32cd to
bed7476
Compare
graalvmbot
force-pushed
the
github/chaeubl/GR-30765
branch
3 times, most recently
from
19dd112 to
a0c943c
Compare
peter-hofer
approved these changes
Aug 5, 2021
Member
peter-hofer
left a comment
peter-hofer
left a comment
There was a problem hiding this comment.
This will be a lot more useful than our current diagnostic output. Thank you!
Comment on lines
+44
to
+49
| PosixUtils.checkStatusIs0(Pthread.pthread_getattr_np(Pthread.pthread_self(), attr), "LinuxStackOverflowSupport: pthread_getattr_np"); | ||
|
|
||
| WordPointer stackaddrPtr = StackValue.get(WordPointer.class); | ||
| WordPointer stacksizePtr = StackValue.get(WordPointer.class); | ||
| PosixUtils.checkStatusIs0(Pthread.pthread_attr_getstack(attr, stackaddrPtr, stacksizePtr), "LinuxStackOverflowSupport: pthread_attr_getstack"); | ||
| PosixUtils.checkStatusIs0(Pthread.pthread_attr_destroy(attr), "LinuxStackOverflowSupport: pthread_attr_destroy"); |
Member
There was a problem hiding this comment.
We should be more fault-tolerant in the context of an segfault handler -- this method may return 0.
Member
There was a problem hiding this comment.
That shouldn't be an issue as the stack boundaries are cached in thread-local values during thread startup. The segfault handler only accesses those thread-local values.
Comment on lines
+44
to
+49
| @Uninterruptible(reason = "Called from uninterruptible code.", mayBeInlined = true) | ||
| @Override | ||
| public UnsignedWord lookupStackBase() { | ||
| int sizeOfMInfo = SizeOf.get(MemoryAPI.MEMORY_BASIC_INFORMATION.class); | ||
| MemoryAPI.MEMORY_BASIC_INFORMATION minfo = StackValue.get(sizeOfMInfo); | ||
| MemoryAPI.VirtualQuery(minfo, minfo, WordFactory.unsigned(sizeOfMInfo)); |
Member
There was a problem hiding this comment.
VirtualQuery can fail, we should handle that.
...oracle.svm.core.windows/src/com/oracle/svm/core/windows/WindowsSubstrateSegfaultHandler.java
Outdated
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/code/CodeInfoAccess.java
Outdated
Show resolved
Hide resolved
...m/src/com.oracle.svm.core/src/com/oracle/svm/core/graal/snippets/StackOverflowCheckImpl.java
Show resolved
Hide resolved
...atevm/src/com.oracle.svm.core/src/com/oracle/svm/core/locks/SingleThreadedVMLockSupport.java
Show resolved
Hide resolved
…chine code instructions.
Refactored DiagnosticThunk.
…pilations via a signal.
…ot use a negative marker value
Fixed output formatting issues. Fixes for printing the RuntimeCodeInfoMemory.
Changed how stack traces are printed for the failing thread.
graalvmbot
force-pushed
the
github/chaeubl/GR-30765
branch
from
58cdb66 to
7c55d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.