Minor cleanups and documentation.

Author: christianhaeubl

substratevm/src/com.oracle.svm.core.windows/src/com/oracle/svm/core/windows/WindowsSubstrateSegfaultHandler.java

@@ -59,6 +59,10 @@ public void afterRegistration(AfterRegistrationAccess access) {
 }
 
 class WindowsSubstrateSegfaultHandler extends SubstrateSegfaultHandler {
+    private static final int EX_READ = 0;
+    private static final int EX_WRITE = 1;
+    private static final int EX_EXECUTE = 8;
+
     @Override
     protected void install() {
         /*
@@ -116,15 +120,15 @@ protected void printSignalInfo(Log log, PointerBase signalInfo) {
         int numParameters = exceptionRecord.NumberParameters();
         if ((exceptionCode == EXCEPTION_ACCESS_VIOLATION() || exceptionCode == EXCEPTION_IN_PAGE_ERROR()) && numParameters >= 2) {
             CLongPointer exInfo = exceptionRecord.ExceptionInformation();
-            long exParam0 = exInfo.addressOf(0).read();
-            if (exParam0 == 0) {
+            long operation = exInfo.addressOf(0).read();
+            if (operation == EX_READ) {
                 log.string(", reading address");
-            } else if (exParam0 == 1) {
+            } else if (operation == EX_WRITE) {
                 log.string(", writing address");
-            } else if (exParam0 == 8) {
+            } else if (operation == EX_EXECUTE) {
                 log.string(", data execution prevention violation at address");
             } else {
-                log.string(", ExceptionInformation=").zhex(exParam0);
+                log.string(", ExceptionInformation=").zhex(operation);
             }
             log.string(" ").zhex(exInfo.addressOf(1).read());
         } else {

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/code/CodeInfoAccess.java

@@ -149,7 +149,7 @@ public static String stateToString(int codeInfoState) {
             case CodeInfo.STATE_CODE_CONSTANTS_LIVE:
                 return "code constants live";
             case CodeInfo.STATE_NON_ENTRANT:
-                return "non entrant";
+                return "non-entrant";
             case CodeInfo.STATE_READY_FOR_INVALIDATION:
                 return "ready for invalidation";
             case CodeInfo.STATE_PARTIALLY_FREED:

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/locks/VMLockSupport.java

@@ -32,8 +32,16 @@
 import com.oracle.svm.core.log.Log;
 
 public abstract class VMLockSupport {
+    /**
+     * Returns an array that contains all {@link VMMutex} objects that are present in the image or
+     * null if that information is not available.
+     */
     public abstract VMMutex[] getMutexes();
 
+    /**
+     * Returns an array that contains all {@link VMCondition} objects that are present in the image
+     * or null if that information is not available.
+     */
     public abstract VMCondition[] getConditions();
 
     public static class DumpVMMutexes extends DiagnosticThunk {