Skip to content

chore: fix http-httpclient module tests not included in travis #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2022
Merged

chore: fix http-httpclient module tests not included in travis #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8a3c16
upgrade jacoco to support Java 11
jaeopt Feb 11, 2022
7e7262a
fix travis missing httpclient-impl tests
jaeopt Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ allprojects {
}

jacoco {
toolVersion = '0.8.0'
toolVersion = '0.8.7'
}
}

Expand Down
4 changes: 4 additions & 0 deletions core-httpclient-impl/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ dependencies {

compile group: 'org.apache.httpcomponents', name: 'httpclient', version: httpClientVersion
}

task exhaustiveTest {
dependsOn('test')
}
2 changes: 2 additions & 0 deletions core-httpclient-impl/src/test/java/com/optimizely/ab/OptimizelyHttpClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ public class OptimizelyHttpClientTest {
@Before
public void setUp() {
System.setProperty("https.proxyHost", "localhost");
// default port (80) returns 404 instead of HttpHostConnectException
System.setProperty("https.proxyPort", "12345");
}

@After
Expand Down