Skip to content

chore: fix http-httpclient module tests not included in travis #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2022
Merged

chore: fix http-httpclient module tests not included in travis #464

merged 2 commits into from
Feb 16, 2022

Conversation

@jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Feb 14, 2022 •
edited
Loading

Summary

  • http-httpclient module is not covered by travis (gradlew exhaustiveTest), which has been fixed.
  • Fix a proxy testing not covered by travis.
  • Upgrade jacoco to support Java 11

@jaeopt jaeopt requested a review from a team as a code owner February 14, 2022 22:44
@coveralls
Copy link

coveralls commented Feb 14, 2022

Pull Request Test Coverage Report for Build 1948

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.741%
Totals Coverage Status
Change from base Build 1942: 0.0%
Covered Lines: 4871
Relevant Lines: 5368
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Feb 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1948

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.741%
Totals Coverage Status
Change from base Build 1942: 0.0%
Covered Lines: 4871
Relevant Lines: 5368
💛 - Coveralls

@jaeopt jaeopt removed their assignment Feb 14, 2022
msohailhussain
msohailhussain approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit 206ae8b into master Feb 16, 2022
@jaeopt jaeopt deleted the jae/gradle-error branch February 16, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🤖 8 hrs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jaeopt @coveralls @msohailhussain @optimizely-codereview-bot