Skip to content

ignore experiment status when bucketing rollout rule experiments #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2017
Merged

ignore experiment status when bucketing rollout rule experiments #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions core-api/src/main/java/com/optimizely/ab/bucketing/DecisionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,7 @@ public DecisionService(@Nonnull Bucketer bucketer,
for (int i = 0; i < rolloutRulesLength - 1; i++) {
Experiment rolloutRule= rollout.getExperiments().get(i);
Audience audience = projectConfig.getAudienceIdMapping().get(rolloutRule.getAudienceIds().get(0));
if (!rolloutRule.isActive()) {
logger.debug("Did not attempt to bucket user into rollout rule for audience \"" +
audience.getName() + "\" since the rule is not active.");
}
else if (ExperimentUtils.isUserInExperiment(projectConfig, rolloutRule, filteredAttributes)) {
if (ExperimentUtils.isUserInExperiment(projectConfig, rolloutRule, filteredAttributes)) {
logger.debug("Attempting to bucket user \"" + userId +
"\" into rollout rule for audience \"" + audience.getName() +
"\".");
Expand Down