ignore experiment status when bucketing rollout rule experiments #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaszurkan-optimizely
approved these changes
Sep 12, 2017
Contributor
thomaszurkan-optimizely
left a comment
thomaszurkan-optimizely
left a comment
There was a problem hiding this comment.
lgtm. but, i have to ask, is it really a good idea to include someone in a rollout that is not active?
Contributor
Author
|
@thomaszurkan-optimizely The rollout rule experiment will be filtered out if not active by the datafile. |
wangjoshuah
deleted the
josh.wang/rollout-bucketing-ignores-experiment-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we do not need to check experiment status since the datafile will not have inactive experiments