Skip to content

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Feb 2, 2023

Summary

  • Added functionality to allow user to pass custom ODPEventManager and odpSegmentManager.
  • parsing fetchQualifiedSegment graphql response in ODPSegmentclient.

Test plan

All tests should pass. Tested with FSC.

Issues

Dependencies

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt
Copy link
Contributor

jaeopt commented Feb 8, 2023

@mnoman09 The interface issue has been fixed with a new SNAPSHOT of java-sdk. We still have one unit test fail, expected after the change. This PR is force-closed since it'll be fixed it in a separate PR.

@jaeopt jaeopt merged commit b724e40 into master Feb 8, 2023
@jaeopt jaeopt deleted the mnoman/customODPManager branch February 8, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants