Skip to content

Refact: ODPAPIManager now returns fetchQualifiedSegments list instead of string #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 8, 2023
Merged

Refact: ODPAPIManager now returns fetchQualifiedSegments list instead of string #503

merged 7 commits into from
Feb 8, 2023

Conversation

@mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Feb 2, 2023

Summary

  • Refactored code of ODPAPIManager fetchQualifiedSegments function to return list of qualifiedSegments. This is to keep it consistent with other SDKs
  • This allows user to override the function and return the qualifiedSegment and they won't have to figure out how to parse the graphql response.

Test plan

Fixed some unit tests according to this new change. All unit tests should pass.

Issues

@mnoman09 mnoman09 requested a review from a team as a code owner February 2, 2023 14:17
@mnoman09 mnoman09 mentioned this pull request Feb 2, 2023
Merged
@mnoman09 mnoman09 removed their assignment Feb 2, 2023
jaeopt
jaeopt approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaeopt
jaeopt requested changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fix suggested to support android-sdk.

@msohailhussain msohailhussain requested a review from jaeopt February 8, 2023 06:09
jaeopt
jaeopt approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 42f8899 into master Feb 8, 2023
@jaeopt jaeopt deleted the mnoman/androidCustomization branch February 8, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@mnoman09 mnoman09

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mnoman09 @jaeopt @optimizely-codereview-bot @NomanShoaib