Fix duplicated CRDs in quickstart manifests. #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 4 commits into operator-framework:master from benluddy:release-fixes

Jun 4, 2020

Contributor

benluddy commented May 22, 2020

The script that generates the quickstart manifest files was dependent on an existing manifest file naming convention (CRD manifest files had the extension .crd.yaml). When the source of truth for CRD manifests was changed to point to the operator-framework/api package, CRD manifests were no longer adhering to that convention.

Since the per-release manifest directories are generated via helm template --include-crds, those CRD manifests are dumped into the same directory as non-CRD manifests.

Rather than attempting any YAML wizardry in package_quickstart.sh to separate CRD manifests from others, this PR simply restores the old naming convention for now.

benluddy added 3 commits

May 22, 2020 09:27


          Don't put CRD manifests into olm.yaml.

ee8492e

Reverts f4060ed.


          Preserve .crd.yaml suffix for manifests copied from api.

dce33a2


          Remove CRD manifests from 0.15.1 quickstart's olm.yaml.

9f79161

openshift-ci-robot requested a review from gallettilance

May 22, 2020 13:45

Collaborator

openshift-ci-robot commented May 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [benluddy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot requested a review from kevinrizza

May 22, 2020 13:45

openshift-ci-robot added the approved label

benluddy force-pushed the release-fixes branch 2 times, most recently from 7d8f6e6 to c4bad31 Compare

May 22, 2020 14:16


          Add test for release installation instructions.

bb104a3

benluddy force-pushed the release-fixes branch from c4bad31 to bb104a3 Compare

May 22, 2020 14:20

benluddy linked an issue

that may be closed by this pull request

0.15.0 install hang #1534

Closed

njhale reviewed

View reviewed changes

Member

njhale left a comment •

edited

Loading

~~I think this looks good -- but I think we should drop the changes to previous release manifest directories~~ this isn't really too big of a deal

Member

njhale commented May 22, 2020

/retest

Member

njhale commented May 22, 2020

/lgtm

openshift-ci-robot assigned njhale

openshift-ci-robot added the lgtm label

kevinrizza reviewed

View reviewed changes

.github/workflows/quickstart.yml

+                      kubectl apply -f deploy/upstream/quickstart/crds.yaml
+                      kubectl wait --timeout=5m --for=condition=Established crd $(kubectl get crd --output=jsonpath='{.items[*].metadata.name}')
+                      kubectl apply -f deploy/upstream/quickstart/olm.yaml
+                      kubectl wait --timeout=5m --for=condition=Available -n olm deploy olm-operator catalog-operator packageserver

Member

kevinrizza Jun 1, 2020

👍

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

27 similar comments

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

benluddy mentioned this pull request

[release] Fix upstream 0.15.1 manifests #1541

Closed

5 tasks

openshift-merge-robot merged commit 1afaf4b into operator-framework:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels