Skip to content

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented May 21, 2020

Manifests for 0.15.1 did not have CRDs annotated as *.crd.yaml.
This PR renames the CRD yamls to *.crd.yaml. Also update the
package_quickstart script to generate quickstart/olm.yaml and
quickstart/crd.yaml files.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Manifests for 0.15.1 did not have CRDs annotated as *.crd.yaml.
This PR renames the CRD yamls to *.crd.yaml. Also update the
package_quickstart script to generate quickstart/olm.yaml and
quickstart/crd.yaml files.
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anik120
To complete the pull request process, please assign kevinrizza
You can assign the PR to them by writing /assign @kevinrizza in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Collaborator

@anik120: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 9adb51e link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benluddy
Copy link
Contributor

benluddy commented Jun 4, 2020

Closing in favor of #1542 which addresses this issue.

@benluddy benluddy closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants