Skip to content

fix: fix event.target still can be pointed by event after finalized by JavaScript GC. #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix: fix event.target still can be pointed by event after finalized by JavaScript GC. #519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2972117
fix: fix event.target still can be pointed by event after finalized b…
andycall Nov 12, 2023
06d4b15
fix: add checks for currentTarget.
andycall Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion webf/lib/src/bridge/binding.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,12 @@ void _dispatchEventToNative(Event event, bool isCapture) {
Pointer<NativeBindingObject>? pointer = event.currentTarget?.pointer;
int? contextId = event.target?.contextId;
WebFController controller = WebFController.getControllerOfJSContextId(contextId)!;
if (contextId != null && pointer != null && pointer.ref.invokeBindingMethodFromDart != nullptr) {
if (contextId != null &&
pointer != null &&
pointer.ref.invokeBindingMethodFromDart != nullptr &&
event.target?.pointer?.ref.disposed != true &&
event.currentTarget?.pointer?.ref.disposed != true
) {
BindingObject bindingObject = controller.view.getBindingObject(pointer);
// Call methods implements at C++ side.
DartInvokeBindingMethodsFromDart f = pointer.ref.invokeBindingMethodFromDart.asFunction();
Expand Down