Skip to content

fix: fix event.target still can be pointed by event after finalized by JavaScript GC. #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix: fix event.target still can be pointed by event after finalized by JavaScript GC. #519

merged 2 commits into from
Nov 14, 2023

Conversation

@andycall
Copy link
Member

image

@andycall andycall force-pushed the fix/event_target_disposed branch from fa9c13d to 06d4b15 Compare November 13, 2023 05:40
@andycall andycall added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit 9eedd16 Nov 14, 2023
@andycall andycall deleted the fix/event_target_disposed branch November 14, 2023 14:02
andycall added a commit that referenced this pull request Nov 16, 2023
@andycall
fix: fix event.target still can be pointed by event after finalized b…
3da3b77 
…y JavaScript GC. (#519)

<img width="901" alt="image"
src="https://github.com/openwebf/webf/assets/4409743/aaf69f14-965e-4cb2-b8a1-1933e87ed8c5">
andycall added a commit that referenced this pull request Nov 18, 2023
@andycall
fix: fix event.target still can be pointed by event after finalized b…
370853c 
…y JavaScript GC. (#519)

<img width="901" alt="image"
src="https://github.com/openwebf/webf/assets/4409743/aaf69f14-965e-4cb2-b8a1-1933e87ed8c5">
andycall added a commit that referenced this pull request Nov 22, 2023
@andycall
fix: fix event.target still can be pointed by event after finalized b…
64c2ce8 
…y JavaScript GC. (#519)

<img width="901" alt="image"
src="https://github.com/openwebf/webf/assets/4409743/aaf69f14-965e-4cb2-b8a1-1933e87ed8c5">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TomesVWhite TomesVWhite TomesVWhite approved these changes

@Ivan-young66 Ivan-young66 Ivan-young66 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andycall @TomesVWhite @Ivan-young66