Skip to content

MCO-1930 MCO-1967: migrate ControlPlaneMachineset tests #5391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

MCO-1930 MCO-1967: migrate ControlPlaneMachineset tests #5391

wants to merge 2 commits into from

Conversation

@sergiordlr
Copy link
Contributor

@sergiordlr sergiordlr commented Nov 4, 2025 •
edited
Loading

- What I did

Created 5 test cases for ControlPlaneMachineSet boot image updates:

PolarionID:85467 - ControlPlaneMachineSets. Bootimage upgrade stub ignition to spec 3

Platforms: AWS, GCP, Azure
Steps:

  1. Verify platform is AWS/GCP/Azure and ManagedBootImagesCPMS feature gate is enabled
  2. Backup original ControlPlaneMachineSet spec
  3. Configure MachineConfiguration with "All" mode for controlplanemachinesets
  4. Convert user-data secret to Ignition v2.2.0 (stub config without storage/systemd)
  5. Set invalid boot image in ControlPlaneMachineSet
  6. Verify MCO upgrades user-data secret to Ignition v3.2.0
  7. Verify MCO corrects boot image to expected version
  8. If CPMS is Active and original userData was stub: delete one machine and verify CPMS recreates it
  9. Restore all original configurations

PolarionID:85478 - ControlPlaneMachineSets. Correctly handle marketplace boot-images

Platforms: GCP, AWS (skips Azure)
Steps:

  1. Set 2.2.0 user-data secret in CPMS
  2. Set fake/non-updateable marketplace boot image
  3. Configure MachineConfiguration with All mode
  4. Verify boot image is NOT updated (Consistently 5m)
  5. Verify user-data secret is NOT updated (Consistently 2m)

PolarionID:85399 - ControlPlaneMachineSets boot-image update. Partial mode not allowed

Platforms: AWS, GCP, Azure
Steps:

  1. Configure MachineConfiguration with Partial mode for CPMS
  2. Verify command fails with error: "Only All or None selection mode is permitted for ControlPlaneMachineSets"

PolarionID:85479 - ControlPlaneMachineSets. Not updated when using Mode: None

Platforms: AWS, GCP, Azure
Steps:

  1. Configure MachineConfiguration with None mode
  2. Set 2.2.0 user-data secret in CPMS
  3. Set wrong boot image in CPMS
  4. Verify boot image is NOT updated (Consistently 3m)
  5. Verify user-data secret is NOT updated (Consistently 1m)

PolarionID:85480 - ControlPlaneMachineSets. Not updated when owner reference

Platforms: AWS, GCP, Azure
Steps:

  1. Add fake owner reference to CPMS
  2. Set 2.2.0 user-data secret in CPMS
  3. Set wrong boot image in CPMS
  4. Configure MachineConfiguration with All mode
  5. Verify boot image is NOT updated (Consistently 3m)
  6. Verify user-data secret is NOT updated (Consistently 1m)

- How to verify it

Execute the payload command using different platforms

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

- Description for the changelog

Add Component Readiness tests for CPMS boot image updates

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2025 •
edited by openshift-ci bot
Loading

@sergiordlr: This pull request references MCO-1930 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

- What I did

Create test cases for Controlplanemachineset

- How to verify it

Execute the payload command using different platforms

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-vsphere-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

- Description for the changelog

Add Component Readiness tests for CPMS boot image updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sergiordlr
Once this PR has been reviewed and has the lgtm label, please assign pablintino for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2025 •
edited by openshift-ci bot
Loading

@sergiordlr: This pull request references MCO-1930 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

- What I did

Create test cases for Controlplanemachineset

- How to verify it

Execute the payload command using different platforms

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-vsphere-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

- Description for the changelog

Add Component Readiness tests for CPMS boot image updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2025 •
edited by openshift-ci bot
Loading

@sergiordlr: This pull request references MCO-1930 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

- What I did

Created 5 test cases for ControlPlaneMachineSet boot image updates:

PolarionID:85467 - ControlPlaneMachineSets. Bootimage upgrade stub ignition to spec 3

Platforms: AWS, GCP, Azure
Steps:

  1. Verify platform is AWS/GCP/Azure and ManagedBootImagesCPMS feature gate is enabled
  2. Backup original ControlPlaneMachineSet spec
  3. Configure MachineConfiguration with "All" mode for controlplanemachinesets
  4. Convert user-data secret to Ignition v2.2.0 (stub config without storage/systemd)
  5. Set invalid boot image in ControlPlaneMachineSet
  6. Verify MCO upgrades user-data secret to Ignition v3.2.0
  7. Verify MCO corrects boot image to expected version
  8. If CPMS is Active and original userData was stub: delete one machine and verify CPMS recreates it
  9. Restore all original configurations

PolarionID:85478 - ControlPlaneMachineSets. Correctly handle marketplace boot-images

Platforms: GCP, AWS (skips Azure)
Steps:

  1. Set 2.2.0 user-data secret in CPMS
  2. Set fake/non-updateable marketplace boot image
  3. Configure MachineConfiguration with All mode
  4. Verify boot image is NOT updated (Consistently 5m)
  5. Verify user-data secret is NOT updated (Consistently 2m)

PolarionID:85399 - ControlPlaneMachineSets boot-image update. Partial mode not allowed

Platforms: AWS, GCP, Azure
Steps:

  1. Configure MachineConfiguration with Partial mode for CPMS
  2. Verify command fails with error: "Only All or None selection mode is permitted for ControlPlaneMachineSets"

PolarionID:85479 - ControlPlaneMachineSets. Not updated when using Mode: None

Platforms: AWS, GCP, Azure
Steps:

  1. Configure MachineConfiguration with None mode
  2. Set 2.2.0 user-data secret in CPMS
  3. Set wrong boot image in CPMS
  4. Verify boot image is NOT updated (Consistently 3m)
  5. Verify user-data secret is NOT updated (Consistently 1m)

PolarionID:85480 - ControlPlaneMachineSets. Not updated when owner reference

Platforms: AWS, GCP, Azure
Steps:

  1. Add fake owner reference to CPMS
  2. Set 2.2.0 user-data secret in CPMS
  3. Set wrong boot image in CPMS
  4. Configure MachineConfiguration with All mode
  5. Verify boot image is NOT updated (Consistently 3m)
  6. Verify user-data secret is NOT updated (Consistently 1m)

- How to verify it

Execute the payload command using different platforms

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

- Description for the changelog

Add Component Readiness tests for CPMS boot image updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sergiordlr sergiordlr force-pushed the mco-migrate-controlplanemachineset-tests branch 2 times, most recently from 2759b06 to caeca3b Compare November 4, 2025 13:10
@sergiordlr
Copy link
Contributor Author

sergiordlr commented Nov 4, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@sergiordlr: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c39fd630-b980-11f0-9e97-b2f3213eb23b-0

@djoshy djoshy mentioned this pull request Nov 4, 2025
Closed
djoshy
djoshy reviewed Nov 4, 2025
View reviewed changes
test/extended-priv/controlplanemachineset.go
switch p := exutil.CheckPlatform(cpms.oc); p {
case AWSPlatform:
patchCoreOsBootImagePath = "/spec/template/machines_v1beta1_machine_openshift_io/spec/providerSpec/value/ami/id"
case GCPPlatform:
Copy link
Contributor

@djoshy djoshy Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be highly unlikely, specially for the CPMS case, but wanted to mention it just in case. We typically do not want to assume the first disk is the boot disk, it is safer to look for the boot: true designator, see #5084

Copy link
Contributor Author

@sergiordlr sergiordlr Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I'll change it to use the boot=true disk

Copy link
Contributor Author

@sergiordlr sergiordlr Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified the code to use the boot=true disk in gcp

djoshy
djoshy reviewed Nov 4, 2025
View reviewed changes
test/extended-priv/mco_controlplanemachineset.go
// Skip if single node
SkipIfSNO(oc.AsAdmin())
// Skip if no machineset
skipTestIfWorkersCannotBeScaled(oc.AsAdmin())
Copy link
Contributor

@djoshy djoshy Nov 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at runs from #5391 (comment), it seems like we're skipping these tests on this check: GCP, AWS. We must be failing this check for some reason?

Copy link
Contributor Author

@sergiordlr sergiordlr Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the code cannot find the machinesets because the resource has a wrong name. I've modified it, now it should run. I've retriggered the execution.

djoshy
djoshy reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@djoshy djoshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the approach of the tests are generally sound. It looks like we are skipping the tests which we'll need to debug.

I do also see some helpers referencing vsphere scenarios, did you mean to leave those in?

@sergiordlr sergiordlr force-pushed the mco-migrate-controlplanemachineset-tests branch from caeca3b to 2e27441 Compare November 4, 2025 18:50
@sergiordlr
Copy link
Contributor Author

sergiordlr commented Nov 4, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@sergiordlr: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f8cfd1f0-b9af-11f0-9e3c-5d67f03797ff-0

@sergiordlr sergiordlr force-pushed the mco-migrate-controlplanemachineset-tests branch from 2e27441 to 5ac00bd Compare November 5, 2025 10:51
@sergiordlr
Copy link
Contributor Author

sergiordlr commented Nov 5, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@sergiordlr: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6bff6ca0-ba35-11f0-9d24-1ad75ea9afcc-0

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Nov 5, 2025

Tests are passing.

Nevertheless, when we remove a controlplane machine so that a new one is recreate the controlplanemachineset resource reports this condition for a brief period of time


  "conditions": [
    {
      "lastTransitionTime": "2025-11-05T06:27:31Z",
      "message": "",
      "observedGeneration": 3,
      "reason": "AsExpected",
      "status": "False",
      "type": "Error"
    },
    {
      "lastTransitionTime": "2025-11-05T06:28:21Z",
      "message": "",
      "observedGeneration": 3,
      "reason": "AllReplicasAvailable",
      "status": "True",
      "type": "Available"
    },
    {
      "lastTransitionTime": "2025-11-05T10:17:31Z",
      "message": "Found 1 unmanaged node(s)",
      "reason": "UnmanagedNodes",
      "status": "True",
      "type": "Degraded"
    },
    {
      "lastTransitionTime": "2025-11-05T06:28:21Z",
      "message": "",
      "reason": "OperatorDegraded",
      "status": "False",
      "type": "Progressing"
    }
  ],
  "observedGeneration": 3,
  "readyReplicas": 3,
  "replicas": 4,
  "updatedReplicas": 3

And it makes the : [Monitor:legacy-cvo-invariants][bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded test case fail.

We can see it in https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-config-operator-5391-periodics-e2e-aws-mco-disruptive-techpreview/1985783257047764992

Is that a bug in the controlplane? is it a problem in the design of the test?

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Nov 5, 2025

/test verify

@sergiordlr sergiordlr force-pushed the mco-migrate-controlplanemachineset-tests branch 2 times, most recently from dfb119c to 283abf1 Compare November 6, 2025 12:33
@sergiordlr sergiordlr changed the title MCO-1930: migrate ControlPlaneMachineset tests MCO-1930 MCO-1967: migrate ControlPlaneMachineset tests Nov 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 6, 2025 •
edited by openshift-ci bot
Loading

@sergiordlr: This pull request references MCO-1930 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

This pull request references MCO-1967 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

- What I did

Created 5 test cases for ControlPlaneMachineSet boot image updates:

PolarionID:85467 - ControlPlaneMachineSets. Bootimage upgrade stub ignition to spec 3

Platforms: AWS, GCP, Azure
Steps:

  1. Verify platform is AWS/GCP/Azure and ManagedBootImagesCPMS feature gate is enabled
  2. Backup original ControlPlaneMachineSet spec
  3. Configure MachineConfiguration with "All" mode for controlplanemachinesets
  4. Convert user-data secret to Ignition v2.2.0 (stub config without storage/systemd)
  5. Set invalid boot image in ControlPlaneMachineSet
  6. Verify MCO upgrades user-data secret to Ignition v3.2.0
  7. Verify MCO corrects boot image to expected version
  8. If CPMS is Active and original userData was stub: delete one machine and verify CPMS recreates it
  9. Restore all original configurations

PolarionID:85478 - ControlPlaneMachineSets. Correctly handle marketplace boot-images

Platforms: GCP, AWS (skips Azure)
Steps:

  1. Set 2.2.0 user-data secret in CPMS
  2. Set fake/non-updateable marketplace boot image
  3. Configure MachineConfiguration with All mode
  4. Verify boot image is NOT updated (Consistently 5m)
  5. Verify user-data secret is NOT updated (Consistently 2m)

PolarionID:85399 - ControlPlaneMachineSets boot-image update. Partial mode not allowed

Platforms: AWS, GCP, Azure
Steps:

  1. Configure MachineConfiguration with Partial mode for CPMS
  2. Verify command fails with error: "Only All or None selection mode is permitted for ControlPlaneMachineSets"

PolarionID:85479 - ControlPlaneMachineSets. Not updated when using Mode: None

Platforms: AWS, GCP, Azure
Steps:

  1. Configure MachineConfiguration with None mode
  2. Set 2.2.0 user-data secret in CPMS
  3. Set wrong boot image in CPMS
  4. Verify boot image is NOT updated (Consistently 3m)
  5. Verify user-data secret is NOT updated (Consistently 1m)

PolarionID:85480 - ControlPlaneMachineSets. Not updated when owner reference

Platforms: AWS, GCP, Azure
Steps:

  1. Add fake owner reference to CPMS
  2. Set 2.2.0 user-data secret in CPMS
  3. Set wrong boot image in CPMS
  4. Configure MachineConfiguration with All mode
  5. Verify boot image is NOT updated (Consistently 3m)
  6. Verify user-data secret is NOT updated (Consistently 1m)

- How to verify it

Execute the payload command using different platforms

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

- Description for the changelog

Add Component Readiness tests for CPMS boot image updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

@sergiordlr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift 283abf1 link true /test e2e-hypershift
ci/prow/bootstrap-unit 283abf1 link false /test bootstrap-unit
ci/prow/e2e-gcp-op-single-node 283abf1 link true /test e2e-gcp-op-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sergiordlr sergiordlr force-pushed the mco-migrate-controlplanemachineset-tests branch from 283abf1 to 893b346 Compare November 11, 2025 18:56
@sergiordlr
Copy link
Contributor Author

sergiordlr commented Nov 11, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

@sergiordlr: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fc8b5310-bf30-11f0-8b55-5c426c9c6d8d-0

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Nov 14, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-2of2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2025

@sergiordlr: trigger 9 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-2of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9b701210-c146-11f0-8f54-763931fc7dc3-0

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Nov 14, 2025

/test e2e-hypershift

@sergiordlr sergiordlr force-pushed the mco-migrate-controlplanemachineset-tests branch from 893b346 to 211e21e Compare November 17, 2025 13:23
@sergiordlr
Copy link
Contributor Author

sergiordlr commented Nov 17, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-2of2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

@sergiordlr: trigger 9 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-2of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c7c30150-c3b8-11f0-99bc-69fe4a6c8bcd-0

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Nov 18, 2025

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-2of2

@sergiordlr
Copy link
Contributor Author

sergiordlr commented Nov 18, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@sergiordlr: trigger 9 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-azure-mco-disruptive-techpreview-2of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-gcp-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c9d1a380-c45c-11f0-9ae0-7bb29c58f93e-0

@neisw
Copy link
Contributor

neisw commented Nov 18, 2025

/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2 openshift/origin#30499

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f203c6a0-c4af-11f0-87c7-573be3dd3407-0

@openshift-ci openshift-ci bot mentioned this pull request Nov 18, 2025
Open
@neisw
Copy link
Contributor

neisw commented Nov 19, 2025

/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2 openshift/origin#30499

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/01717010-c537-11f0-95ce-ea0fd8c16a1c-0

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2025
@neisw
Copy link
Contributor

neisw commented Nov 19, 2025

/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2 openshift/origin#30499

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6f57e5f0-c537-11f0-9a9b-4a783768564f-0

@sergiordlr sergiordlr force-pushed the mco-migrate-controlplanemachineset-tests branch from 211e21e to 3cd57bd Compare November 19, 2025 17:14
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2025
@neisw
Copy link
Contributor

neisw commented Nov 19, 2025

/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2 openshift/origin#30499

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/83531850-c572-11f0-98e7-f0107eb5275d-0

@neisw
Copy link
Contributor

neisw commented Nov 19, 2025

/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2 openshift/origin#30499

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6ef82930-c578-11f0-881c-71f12e505990-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

1 more reviewer

@djoshy djoshy djoshy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sergiordlr @openshift-ci-robot @neisw @djoshy @openshift-merge-robot