Skip to content

Conversation

@djoshy
Copy link
Contributor

@djoshy djoshy commented May 28, 2025

- What I did
Add an additional check for boot:true, before updating the providerSpec.

- How to verify it
See bug for reproduction steps.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 28, 2025
@openshift-ci-robot
Copy link
Contributor

@djoshy: This pull request references Jira Issue OCPBUGS-55830, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did
Add an additional check for boot:true, before updating the providerSpec.

- How to verify it
See bug for reproduction steps.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor Author

djoshy commented May 28, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-serial periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2025

@djoshy: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d42a2da0-3bec-11f0-8f05-cce20accb912-0

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@djoshy
Copy link
Contributor Author

djoshy commented May 28, 2025

/cherry-pick release-4.19 release-4.18 release-4.17

/jira refresh

@openshift-cherrypick-robot

@djoshy: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19 release-4.18 release-4.17

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 28, 2025
@openshift-ci-robot
Copy link
Contributor

@djoshy: This pull request references Jira Issue OCPBUGS-55830, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

In response to this:

/cherry-pick release-4.19 release-4.18 release-4.17

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from miyadav May 28, 2025 17:59
@djoshy djoshy force-pushed the only-update-boot-disk-gcp branch from 2082b9d to 838f31d Compare May 28, 2025 18:45
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@djoshy
Copy link
Contributor Author

djoshy commented May 28, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-serial periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-serial

@djoshy
Copy link
Contributor Author

djoshy commented May 28, 2025

/hold

holding for payloads and QE testing if required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2025

@djoshy: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7657f420-3bf4-11f0-960a-6d371eb17624-0

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djoshy
Copy link
Contributor Author

djoshy commented May 28, 2025

/test unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2025

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-techpreview 838f31d link false /test e2e-hypershift-techpreview
ci/prow/e2e-azure-ovn-upgrade-out-of-change 838f31d link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl 838f31d link false /test e2e-gcp-op-ocl
ci/prow/e2e-aws-ovn-upgrade-out-of-change 838f31d link false /test e2e-aws-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@djoshy
Copy link
Contributor Author

djoshy commented May 29, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2025
@djoshy
Copy link
Contributor Author

djoshy commented May 29, 2025

Payloads are green, will do QE testing post merge

@openshift-merge-bot openshift-merge-bot bot merged commit 7d51ed8 into openshift:main May 29, 2025
16 of 20 checks passed
@openshift-ci-robot
Copy link
Contributor

@djoshy: Jira Issue OCPBUGS-55830: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-55830 has not been moved to the MODIFIED state.

In response to this:

- What I did
Add an additional check for boot:true, before updating the providerSpec.

- How to verify it
See bug for reproduction steps.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@djoshy: new pull request created: #5088

In response to this:

/cherry-pick release-4.19 release-4.18 release-4.17

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.20.0-202505290215.p0.g7d51ed8.assembly.stream.el9.
All builds following this will include this PR.

@djoshy djoshy deleted the only-update-boot-disk-gcp branch June 13, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants