Skip to content

Conversation

@smg247
Copy link
Member

@smg247 smg247 commented Jul 21, 2025

Reverts #2398 ; tracked by OCPBUGS-59574

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR causes the '[sig-auth][Feature:SCC][Early] should not have pod creation failures during install [Suite:openshift/conformance/parallel]' test to fail in 'Aggregated-aws-ovn-upgrade-4.20-micro-fips' and 'Aws-ovn-techpreview-serial'

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

CC: @everettraven

PR created by Revertomatic™️

…89-revert-2138-remove-rbr-crd-from-payload"

This reverts commit 3333746, reversing
changes made to 2562429.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 21, 2025
@openshift-ci-robot
Copy link

@smg247: This pull request references Jira Issue OCPBUGS-59574, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #2398 ; tracked by OCPBUGS-59574

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR causes the '[sig-auth][Feature:SCC][Early] should not have pod creation failures during install [Suite:openshift/conformance/parallel]' test to fail in 'Aggregated-aws-ovn-upgrade-4.20-micro-fips' and 'Aws-ovn-techpreview-serial'

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

'should not have pod creation failures during install test failures' fails

CC: @everettraven

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2025

Hello @smg247! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k July 21, 2025 13:53
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2025
@smg247
Copy link
Member Author

smg247 commented Jul 21, 2025

/override ci/prow/verify-client-go
/override ci/prow/e2e-aws-serial-techpreview-2of2
/override ci/prow/e2e-aws-ovn-techpreview
/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-ovn
/override ci/prow/build
/override ci/prow/e2e-upgrade-out-of-change
/override ci/prow/e2e-upgrade
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-azure
/override ci/prow/e2e-aws-serial-1of2
/override ci/prow/e2e-aws-serial-techpreview-1of2
/override ci/prow/e2e-aws-serial-2of2
/override ci/prow/e2e-aws-ovn-hypershift-conformance
/override ci/prow/verify-feature-promotion
/override ci/prow/verify-crd-schema
/override ci/prow/minor-e2e-upgrade-minor
/override ci/prow/integration
/override ci/prow/e2e-gcp

@smg247
Copy link
Member Author

smg247 commented Jul 21, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 21, 2025
@openshift-ci-robot
Copy link

@smg247: This pull request references Jira Issue OCPBUGS-59574, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xingxingxia July 21, 2025 13:59
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2025

@smg247: Overrode contexts on behalf of smg247: ci/prow/build, ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-hypershift, ci/prow/e2e-aws-ovn-hypershift-conformance, ci/prow/e2e-aws-ovn-techpreview, ci/prow/e2e-aws-serial-1of2, ci/prow/e2e-aws-serial-2of2, ci/prow/e2e-aws-serial-techpreview-1of2, ci/prow/e2e-aws-serial-techpreview-2of2, ci/prow/e2e-azure, ci/prow/e2e-gcp, ci/prow/e2e-upgrade, ci/prow/e2e-upgrade-out-of-change, ci/prow/integration, ci/prow/minor-e2e-upgrade-minor, ci/prow/okd-scos-e2e-aws-ovn, ci/prow/verify-client-go, ci/prow/verify-crd-schema, ci/prow/verify-feature-promotion

In response to this:

/override ci/prow/verify-client-go
/override ci/prow/e2e-aws-serial-techpreview-2of2
/override ci/prow/e2e-aws-ovn-techpreview
/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-ovn
/override ci/prow/build
/override ci/prow/e2e-upgrade-out-of-change
/override ci/prow/e2e-upgrade
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-azure
/override ci/prow/e2e-aws-serial-1of2
/override ci/prow/e2e-aws-serial-techpreview-1of2
/override ci/prow/e2e-aws-serial-2of2
/override ci/prow/e2e-aws-ovn-hypershift-conformance
/override ci/prow/verify-feature-promotion
/override ci/prow/verify-crd-schema
/override ci/prow/minor-e2e-upgrade-minor
/override ci/prow/integration
/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

@smg247: This pull request references Jira Issue OCPBUGS-59574, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

Reverts #2398 ; tracked by OCPBUGS-59574

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR causes the '[sig-auth][Feature:SCC][Early] should not have pod creation failures during install [Suite:openshift/conformance/parallel]' test to fail in 'Aggregated-aws-ovn-upgrade-4.20-micro-fips' and 'Aws-ovn-techpreview-serial'

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

CC: @everettraven

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2025

@smg247: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5205e27 into openshift:master Jul 21, 2025
27 checks passed
@openshift-ci-robot
Copy link

@smg247: Jira Issue OCPBUGS-59574: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-59574 has been moved to the MODIFIED state.

In response to this:

Reverts #2398 ; tracked by OCPBUGS-59574

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR causes the '[sig-auth][Feature:SCC][Early] should not have pod creation failures during install [Suite:openshift/conformance/parallel]' test to fail in 'Aggregated-aws-ovn-upgrade-4.20-micro-fips' and 'Aws-ovn-techpreview-serial'

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

CC: @everettraven

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202507211916.p0.g5205e27.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants