Skip to content

Revert "Revert "CNTRLPLANE-72: remove RoleBindingRestriction CRD from payload"" #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Revert "Revert "CNTRLPLANE-72: remove RoleBindingRestriction CRD from payload"" #2398

merged 1 commit into from
Jul 18, 2025

Conversation

@everettraven
Copy link
Contributor

@everettraven everettraven commented Jul 9, 2025

Reverts #2389 to add the changes from #2138 back

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 9, 2025 •
edited by openshift-ci bot
Loading

@everettraven: This pull request references CNTRLPLANE-72 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Reverts #2389 to add the changes from #2138 back

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

Hello @everettraven! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@everettraven
Copy link
Contributor Author

everettraven commented Jul 9, 2025

/test all

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2025
@everettraven
Copy link
Contributor Author

everettraven commented Jul 9, 2025

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-fips 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-fips

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c501ced0-5cc8-11f0-96b2-d8e41e43ca56-0

@everettraven
Copy link
Contributor Author

everettraven commented Jul 9, 2025

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-fips 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-fips

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c6a38200-5cf6-11f0-9d92-2f57a37cd570-0

@everettraven
Copy link
Contributor Author

everettraven commented Jul 10, 2025

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-fips 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2025

@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-fips

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f8330000-5d89-11f0-87c6-b66c0945adcf-0

@neisw
Copy link
Contributor

neisw commented Jul 10, 2025

/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/40407170-5d99-11f0-82ec-92156558b606-0

@everettraven everettraven marked this pull request as ready for review July 10, 2025 17:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k July 10, 2025 17:32
@neisw
Copy link
Contributor

neisw commented Jul 10, 2025

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-rt 10

@everettraven
Copy link
Contributor Author

everettraven commented Jul 10, 2025

So far, payload testing is showing that the problem that caused us to revert this change originally is no longer happening with this change in place.

@neisw is going to fire off another round of testing, but I'm moving this out of draft since I do want to get this in sooner than later.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-rt

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ff77f20-5db4-11f0-92c8-d40967799799-0

@neisw
Copy link
Contributor

neisw commented Jul 10, 2025

Agree, we have not seen any job failures due to [sig-auth][Feature:SCC][Early] should not have pod creation failures during install [Suite:openshift/conformance/parallel] in any of the testing that has been run. No reason to hold off merging this back in that we can see.

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Jul 11, 2025

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2025

/retest-required

Remaining retests: 0 against base HEAD 674ad74 and 2 for PR HEAD deda75c in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2025

/retest-required

Remaining retests: 0 against base HEAD 674ad74 and 2 for PR HEAD deda75c in total

@everettraven
Copy link
Contributor Author

everettraven commented Jul 14, 2025

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 14, 2025

/retest-required

Remaining retests: 0 against base HEAD 674ad74 and 2 for PR HEAD deda75c in total

@everettraven
Copy link
Contributor Author

everettraven commented Jul 15, 2025

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2025

/retest-required

Remaining retests: 0 against base HEAD 674ad74 and 2 for PR HEAD deda75c in total

2 similar comments
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 16, 2025

/retest-required

Remaining retests: 0 against base HEAD 674ad74 and 2 for PR HEAD deda75c in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 16, 2025

/retest-required

Remaining retests: 0 against base HEAD 674ad74 and 2 for PR HEAD deda75c in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 16, 2025

/retest-required

Remaining retests: 0 against base HEAD e375905 and 1 for PR HEAD deda75c in total

@everettraven
Copy link
Contributor Author

everettraven commented Jul 16, 2025

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 16, 2025

/retest-required

Remaining retests: 0 against base HEAD e375905 and 2 for PR HEAD deda75c in total

2 similar comments
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2025

/retest-required

Remaining retests: 0 against base HEAD e375905 and 2 for PR HEAD deda75c in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2025

/retest-required

Remaining retests: 0 against base HEAD e375905 and 2 for PR HEAD deda75c in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2025

/retest-required

Remaining retests: 0 against base HEAD 933316e and 2 for PR HEAD deda75c in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2025

/retest-required

Remaining retests: 0 against base HEAD ba53b2a and 1 for PR HEAD deda75c in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2025

/retest-required

Remaining retests: 0 against base HEAD ba53b2a and 2 for PR HEAD deda75c in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 18, 2025

/retest-required

Remaining retests: 0 against base HEAD 87ff3fc and 1 for PR HEAD deda75c in total

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Jul 18, 2025

/override ci/prow/minor-e2e-upgrade-minor

Failing on a known issue, waiting for the 4.19 candidate channel to pick up the 4.19 revert

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/minor-e2e-upgrade-minor

In response to this:

/override ci/prow/minor-e2e-upgrade-minor

Failing on a known issue, waiting for the 4.19 candidate channel to pick up the 4.19 revert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2025 •
edited
Loading

@everettraven: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure deda75c link false /test e2e-azure
ci/prow/okd-scos-e2e-aws-ovn deda75c link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 18, 2025

/retest-required

Remaining retests: 0 against base HEAD 2562429 and 0 for PR HEAD deda75c in total

@openshift-merge-bot openshift-merge-bot bot merged commit 3333746 into openshift:master Jul 18, 2025
25 of 27 checks passed
smg247 added a commit to smg247/api that referenced this pull request Jul 21, 2025
@smg247
Revert "Merge pull request openshift#2398 from everettraven/revert-23…
4e99470 
…89-revert-2138-remove-rbr-crd-from-payload"

This reverts commit 3333746, reversing
changes made to 2562429.
@smg247 smg247 mentioned this pull request Jul 21, 2025
Merged
openshift-merge-bot bot added a commit that referenced this pull request Jul 21, 2025
@openshift-merge-bot
Merge pull request #2414 from smg247/revert-2398-1753105926045
5205e27 
OCPBUGS-59574: Revert #2398 "Revert \"Revert \"CNTRLPLANE-72: remove RoleBindingRestriction CRD from payload\"\""
isabella-janssen pushed a commit to isabella-janssen/openshift-api that referenced this pull request Aug 11, 2025
@smg247 @isabella-janssen
Revert "Merge pull request openshift#2398 from everettraven/revert-23…
a10e134 
…89-revert-2138-remove-rbr-crd-from-payload"

This reverts commit 3333746, reversing
changes made to 2562429.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@everettraven @openshift-ci-robot @neisw @JoelSpeed