-
Notifications
You must be signed in to change notification settings - Fork 6.2k
JDK-8253700: spurious "extends Throwable" at end of Optional.orElseThrow method declaration #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jonathan-gibbons
wants to merge
1
commit into
openjdk:master
from
jonathan-gibbons:8253700.extends-Throwable
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
test/langtools/jdk/javadoc/doclet/testThrows/TestThrows.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| /* | ||
| * @test | ||
| * @bug 8253700 | ||
| * @summary spurious "extends Throwable" at end of method declaration | ||
| * throws section. Make sure that the link is below a Throws heading. | ||
| * @library /tools/lib ../../lib | ||
| * @modules jdk.javadoc/jdk.javadoc.internal.tool | ||
| * @build javadoc.tester.* toolbox.ToolBox | ||
| * @run main TestThrows | ||
| */ | ||
|
|
||
| import java.io.IOException; | ||
| import java.nio.file.Path; | ||
|
|
||
| import toolbox.ToolBox; | ||
|
|
||
| import javadoc.tester.JavadocTester; | ||
|
|
||
| public class TestThrows extends JavadocTester { | ||
|
|
||
| public static void main(String... args) throws Exception { | ||
| TestThrows tester = new TestThrows(); | ||
| tester.runTests(m -> new Object[] { Path.of(m.getName()) }); | ||
| } | ||
|
|
||
| private final ToolBox tb = new ToolBox(); | ||
|
|
||
| @Test | ||
| public void testThrowsWithBound(Path base) throws IOException { | ||
| Path src = base.resolve("src"); | ||
| tb.writeJavaFiles(src, | ||
| """ | ||
| /** | ||
| * This is interface C. | ||
| */ | ||
| public interface C { | ||
| /** | ||
| * Method m. | ||
| * @param <T> the throwable | ||
| * @throws T if a specific error occurs | ||
| * @throws Exception if an exception occurs | ||
| */ | ||
| <T extends Throwable> void m() throws T, Exception; | ||
| } | ||
| """); | ||
|
|
||
| javadoc("-d", base.resolve("out").toString(), | ||
| src.resolve("C.java").toString()); | ||
| checkExit(Exit.OK); | ||
|
|
||
| checkOutput("C.html", true, | ||
| """ | ||
| <div class="member-signature"><span class="type-parameters"><T extends java\ | ||
| .lang.Throwable></span> <span class="return-type">void</span> <sp\ | ||
| an class="member-name">m</span>() | ||
| throws <span class="exceptions">T, | ||
| java.lang.Exception</span></div> | ||
| """, | ||
| """ | ||
| <dl class="notes"> | ||
| <dt>Type Parameters:</dt> | ||
| <dd><code>T</code> - the throwable</dd> | ||
| <dt>Throws:</dt> | ||
| <dd><code>T</code> - if a specific error occurs</dd> | ||
| <dd><code>java.lang.Exception</code> - if an exception occurs</dd> | ||
| </dl> | ||
| """); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reminds me of the 8238966: Use a better way of joining things together.