Skip to content

8365512: Replace -Xcomp with -Xmixed for AOT assembly phase #26767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

8365512: Replace -Xcomp with -Xmixed for AOT assembly phase #26767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08bd075
8365512: Replace -Xcomp with -Xmixed for AOT assembly phase
vnkozlov Aug 13, 2025
60861d3
Update comment
vnkozlov Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/hotspot/share/cds/cdsConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,8 +643,17 @@ bool CDSConfig::check_vm_args_consistency(bool patch_mod_javabase, bool mode_fla
}

if (is_dumping_static_archive()) {
if (is_dumping_preimage_static_archive() || is_dumping_final_static_archive()) {
// Don't tweak execution mode
if (is_dumping_preimage_static_archive()) {
// Don't tweak execution mode during AOT training run
} else if (is_dumping_final_static_archive()) {
if (Arguments::mode() == Arguments::_comp) {
// AOT assembly phase submits the non-blocking compilation requests
// for methods collected during training run, then waits for all compilations
// to complete. With -Xcomp, we block for each compilation request, which is
// counter-productive. Switching back to mixed mode improves testing time
// with AOT and -Xcomp.
Arguments::set_mode_flags(Arguments::_mixed);
}
} else if (!mode_flag_cmd_line) {
// By default, -Xshare:dump runs in interpreter-only mode, which is required for deterministic archive.
//
Expand Down