-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8365512: Replace -Xcomp with -Xmixed for AOT assembly phase #26767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back kvn! A progress list of the required criteria for merging this PR into |
@vnkozlov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable. I think the comment needs to be more explicit what and why we are doing this thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you @shipilev |
/integrate |
Going to push as commit a65f200.
Your commit was automatically rebased without conflicts. |
When debugging AOT code generation in Leyden repo I noticed that AOT JIT compilations are serial with -Xcomp even so we create a lot of compiler threads to speed up. It is because -Xcomp enforce blocking compilation and only one thread submits AOT compilations. Also -Xcomp triggers a lot more other, not AOT, compilations which we don't need during assembly phase.
I suggest to replace -Xcomp with -Xmixed for AOT assembly phase.
I want to push it into mainline first because in mainline we don't even do AOT compilation yet.
This should speed up AOT testing with -Xcomp.
Tested tier1-6,8,10 (-rt)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26767/head:pull/26767
$ git checkout pull/26767
Update a local copy of the PR:
$ git checkout pull/26767
$ git pull https://git.openjdk.org/jdk.git pull/26767/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26767
View PR using the GUI difftool:
$ git pr show -t 26767
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26767.diff
Using Webrev
Link to Webrev Comment