-
Notifications
You must be signed in to change notification settings - Fork 5.9k
opencv-4.5.4 enable_cvv fixes #3063 #3072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note that HAVE_QT can mean Qt 4, 5 or 6. So you need to check that the found Qt version is actually compatible with cvv code. |
|
I agree, |
|
Thank you for contribution! This patch should go into 3.4 branch first. Please:
Note: no needs to re-open PR, apply changes "inplace". |
and for QT6, can we enable it ? or is known that is not working for QT6 and we also should disable it ? |
The cvv module is compiled conditionally on HAVE_QT5. But in opencv commit 87d4970 this variable was renamed to HAVE_QT, so the module is never compiled. Also check if QT_VERSION_MAJOR >= 5
done, I propose add if not HAVE_QT OR QT_VERSION_MAJOR LESS 5 , disable it, allowing build on QT6 ! |
alalek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Thank you 👍
The cvv module is compiled conditionally on HAVE_QT5. But in opencv commit 87d4970 this variable was renamed to HAVE_QT, so the module is never compiled.
fixes #3063
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.