Improving the disparity filter interface #303
Conversation
There was a problem hiding this comment.
I'd suggest to divide this method to:
createDisparityWLSFilter(left_matcher)
// and
setupRightMatcher(left_matcher) // or 'createRightMatcher'
|
Looks good, thank you! |
Now the filter natively supports StereoBM and StereoSGBM with no parameter tuning required. Also, now user won't need to set the ROI and the right matcher parameters manually, it is all done in the respective convenience factory method based on the left matcher instance. Tutorial was added to clarify the provided example of use.
sbokov
force-pushed
the
improvingStereoSGBM
branch
from
f8889a8 to
6a0545e
Compare
|
@mshabunin I replaced the code in the tutorial with a link to GitHub and squashed all the commits |
|
👍 |
|
Is it possible that this change introduced this error when building: |
|
@Arqu , please use latest master branch version of opencv repository when building latest version of opencv_contrib. This mode has been added recently: |
|
Thanks, I'll rebuild it when I get some spare time, I've managed to skip the module in the build process for now. I probably didn't use the latest source as I've used the 3.0.0 branch instead of master. |
4 participants
Several changes to minimize the need for explicit parameter tuning when using with either StereoBM or StereoSGBM and to make the filter more easy to use in general.