Skip to content

Conversation

szk1509
Copy link
Contributor

@szk1509 szk1509 commented Mar 12, 2019

This pullrequest introduce the detection of inverted markers.

i.e. it allows detecting white markers on a black background

@alalek
Copy link
Member

alalek commented Mar 13, 2019

Add tests for new feature:

  • to ensure that it works really
  • to ensure that it will not be broken by mistake in the future
  • simple test is one of the best documentation for the code

P.S. Please "cleanup" your commits - squash them into one. Also check "Author"'s email of the first commit at least (GitHub doesn't recognize it).

@alalek
Copy link
Member

alalek commented Mar 29, 2019

BTW, No need to re-open PRs. You can push changes on existed branches (with "--force" option).

@szk1509 szk1509 deleted the invertMarker branch August 21, 2019 20:13
@szk1509 szk1509 restored the invertMarker branch August 21, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants