Exclude myelin from synapse target selector #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should also applied in v2 |
bilalesi
approved these changes
Sep 5, 2025
|
Thank you, @bilalesi. Now it's actually not clear, last time Darshan suggested to keep the myelin in the selector and fix the underlying issue so that people can generate synapses on it. I'll keep this for some time and if not needed - will close it. P.S. I should have put that notification in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting myelin as a target for synapses is not meaningful so this change excludes that from the selector.
Relates to https://github.com/openbraininstitute/prod-singlecell-simulation/issues/103.