DO_NOT_MERGE task/v2 #696
Open
DO_NOT_MERGE task/v2 #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* redirect temporarly to v2 * update setup workspace on login/redirect * update subscription process, profile * update stripe forms
tolokoban
previously approved these changes
Aug 12, 2025
There was a problem hiding this comment.
Big an great job here, Bilal!
The code is cleaner now and the UI easier to undersand.
TanStack Query is a great asset.
Though, personally, I wouldn't have used useQuery() directly inside components.
I would have rather created custom hooks to abstract the data provider. Just to lower the dependency on this library that could be replaced in the future if something better emerges.
| const breakpoint = useDefaultBreakpoint(); | ||
| const { virtualLabId, projectId } = useWorkspace(); | ||
|
|
||
| const { data, isLoading, isError, isSuccess, error } = useQuery({ |
There was a problem hiding this comment.
Personally I would have preferred to create a specific hook (ex: useWalletData()). This way we could abstract a bit the use of TanStack Queries, in case we change it in the future.
But that's a matter of taste, and it's just my opinion. I will approve anyway.
There was a problem hiding this comment.
i totally agree, I would do that too, the reason i did not, is to have v2 as quickly as possible,
i think if we have it less then the time expected, we can ask for few days to refactor those
fix brain region tree scroll issue fix layout for ai assistant expand
* add explore browse page * add library layout
* Added the content for each features * Added AI Tools * Clean query params when changing the main tabs * Fixed the render of ai-tools in content.tsx * Updated the pmpm-lock.yaml * Added icon to code block and fixed pnpm installation * Changed to Zod, use server side rendering when possible * Place queryKeys into ui/use-query-keys/help.ts * Added prefix to the help query-keys in ui
* add library listing page
* add library listing page * add library listing page * add mini detail view feature
* add cell composition to the main part of explore
* add workflow components, pages, configuration * remove error boundary and use notifications (#743)
fix publication time
add wallet click on admin role
add mini-details-view for simulation
- fix links - add warning in form validation in simulation - fix: resolve mini detail view state management and improve form validation - reset mini detail view when navigating between data scopes - fix null/undefined checks using lodash isNil utility - improve error messaging in simulation forms - add proper React keys to prevent component state issues - clean up login redirect logic and enhance tooltip styling
- fix memodel and synaptome build
fix logout page fix alternate morphology download
fix profile in space switcher
* Rename * div * breadcrumbs * Fetch entity * breadcrumbs * fetch on server * Use slug * navigation * root redirect to overview * actions * copy action * Add actoins * working on bookmarks * add bookmark categories * add bookmark * bookmark funtion * Download * lint * lint * bookmarks * bookmarkCategory: * Linting * restore lefthook for now * restore lefthook for now * download entity * Working on detail view * Add overview page * add morphology page * add electrophysiology viz * prettier * entity one required * Feedback * minor * remove unused routes * Redirect to overview * Visualization * analysis tab * emodel related artifacts * ion channel to ion channel model * emodel, memodel * add synaptome * clean up * circuit * fields * add single neuron simulation * results * add synaptome * add synaptome * redirect detail root to overview * adding name to pages * name * explore -> data * remove double name * add related publications tab * main scree * add circuit viz * Add circuit analysis * add related publications * add mtype, etype to synaptome * add related circuits * add microcircuit * lint * fix analysis * implement back * fix circuit fields layout * viz in overview for circuite * tabbed component * improve styles of related publications * add tabs * provenance * improve analysis styles * improve layout * Default message * move viz to overview * ephys viewer * working on fields * fix render mtypes, etypes * Add mtype etypes * header layout * improve analysis style * implemente simulate action * Clone MEModel * simulate * remove unused console.log
…810) * Minor visual changes to data browser left panel inline with mockups
add downloading subtitle in download panel
- showing activities in the first screen - user can open a new workflow
* vlab name too long * return back to member list after successful invite/add operation * order project in the space switcher by updated_at
…e related publications. (#840)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE