Skip to content

Conversation

bilalesi
Copy link
Collaborator

this is the first step to have extensible types

NOTE

  • entitycore has the default types which you can find in src/api/entitycore/types/entity-type.ts
    but now we have different subtypes that should be treated as first class citizen so in this PR we extend the types of entity core with new one that are basically scale (ex: for circuit) or origin (for cell-recording) (may be others later) properties
  • this also will get rid of the legacy types that are renamed by entitycore which help us to maintain only one set of types
  • this PR will have need another PR to use Dict instead of Enum which help extension of the original types rather then creating another Enum, just to keep on object to maintain
  • this change also require a change in virtual lab to use new types for bookmarks

@bilalesi bilalesi merged commit 059ce15 into task/v2 Aug 13, 2025
4 checks passed
@bilalesi bilalesi deleted the refactor/entity-extensible-types branch August 13, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants