-
Notifications
You must be signed in to change notification settings - Fork 933
Update portable platform file #9470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jsquyres
merged 2 commits into
open-mpi:master
from
bwbarrett:feature/update-portable-platform
Oct 6, 2021
Merged
Update portable platform file #9470
jsquyres
merged 2 commits into
open-mpi:master
from
bwbarrett:feature/update-portable-platform
Oct 6, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix escapling and simplify handling of literals in the OPAL_CHECK_- COMPILER_VERSION_ID macro. The macros were under-escaped,, which was not causing problems but was also wrong. The use of m4_lower() meant that the argument to the helper macros had to be a string literal, so enforce that requirement explicitly and then remove the evals that are unnecessary given the lack of shell expansion. Signed-off-by: Brian Barrett <[email protected]>
Member
|
Got some compile warnings. In ompi_info (similar ones appear in the op/avx component): And in oshmem_info: |
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Oct 5, 2021
Ported from open-mpi/ompi#9470 "The portable platform file hasn't been updated since Feb 10, 2010 (3ca8adb), so it was a bit out of date, including not understanding CLANG and the Nvidia-rebranded PGI compiler, so pull in the latest version from GASNet. Update some of the infrastructure so that we can pull in the GASNet version unchanged and make future updates easier." Signed-off-by: Ralph Castain <[email protected]>
Update the portable platform file from GASNet, as we had last pulled changes sometime before 2013. At the same time, make the infrastructure slightly easier to make future updates. To simplify updates, we move the GASNet header to opal_portable_platform_real.h and provide wrappers in opal_portable_platform.h and mpi.h to avoid compiler warnings from the GASNet header. In theory, future updates should be as somple as copying gasnet_portable_platform.h into opal_portable_platform_real.h. Somewhere in the last decade, GASNet switched from _STRINGIFY to PLATFORM_STRINGIFY, so update all the places we used _STRINGIFY. Signed-off-by: Brian Barrett <[email protected]>
f6b5891 to
d6bfdf2
Compare
|
The IBM CI (GNU/Scale) build failed! Please review the log, linked below. Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6 |
Member
|
restarting IBM CI in 2 minutes. |
Member
|
bot:ibm:retest |
Member
Author
|
bot:aws:retest (Cray timeout) |
jsquyres
approved these changes
Oct 6, 2021
This was referenced Oct 6, 2021
rhc54
added a commit
to rhc54/prrte
that referenced
this pull request
Oct 6, 2021
Ported from open-mpi/ompi#9470 "The portable platform file hasn't been updated since Feb 10, 2010 (3ca8adb), so it was a bit out of date, including not understanding CLANG and the Nvidia-rebranded PGI compiler, so pull in the latest version from GASNet. Update some of the infrastructure so that we can pull in the GASNet version unchanged and make future updates easier." Signed-off-by: Ralph Castain <[email protected]>
rhc54
added a commit
to rhc54/prrte
that referenced
this pull request
Oct 6, 2021
Ported from open-mpi/ompi#9470 "The portable platform file hasn't been updated since Feb 10, 2010 (3ca8adb), so it was a bit out of date, including not understanding CLANG and the Nvidia-rebranded PGI compiler, so pull in the latest version from GASNet. Update some of the infrastructure so that we can pull in the GASNet version unchanged and make future updates easier." Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit e35eff2)
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Oct 6, 2021
Ported from open-mpi/ompi#9470 "The portable platform file hasn't been updated since Feb 10, 2010 (3ca8adb), so it was a bit out of date, including not understanding CLANG and the Nvidia-rebranded PGI compiler, so pull in the latest version from GASNet. Update some of the infrastructure so that we can pull in the GASNet version unchanged and make future updates easier." Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 1bb5f81)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The portable platform file hasn't been updated since Feb 10, 2010 (3ca8adb), so it was a bit out of date, including not understanding CLANG and the Nvidia-rebranded PGI compiler, so pull in the latest version from GASNet. Update some of the infrastructure so that we can pull in the GASNet version unchanged and make future updates easier.
This should allow us to pull in #9398.