Disable support for GCC < v4.8.1 #9398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwbarrett
requested changes
Sep 21, 2021
jsquyres
force-pushed
the
pr/compiler-updates-and-misc-updates
branch
from
e913ef4 to
65fcf57
Compare
bwbarrett
approved these changes
Sep 21, 2021
jsquyres
added a commit
to jsquyres/pmix-master
that referenced
this pull request
Sep 21, 2021
This is a port from the corresponding open-mpi/ompi#9398. OpenPMIx does not compile with GCC 4.4.7 (the default GCC that ships in RHEL 6). Open PMIx *does* compile with GCC 4.8.5 (the default GCC that ships with RHEL 7). The Open MPI community regularly tests Open MPI (including PMIx) with GCC 4.8.1, so we know that works, too. Hence, abort configure if GCC is used and GCC is < v4.8.1. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
added a commit
to jsquyres/pmix-master
that referenced
this pull request
Sep 21, 2021
This is a port from the corresponding open-mpi/ompi#9398. OpenPMIx does not compile with GCC 4.4.7 (the default GCC that ships in RHEL 6). Open PMIx *does* compile with GCC 4.8.5 (the default GCC that ships with RHEL 7). The Open MPI community regularly tests Open MPI (including PMIx) with GCC 4.8.1, so we know that works, too. Hence, abort configure if GCC is used and GCC is < v4.8.1. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
added a commit
to jsquyres/prrte
that referenced
this pull request
Sep 21, 2021
This is a port from the corresponding open-mpi/ompi#9398. PRTE does not compile with GCC 4.4.7 (the default GCC that ships in RHEL 6). PRTE *does* compile with GCC 4.8.5 (the default GCC that ships with RHEL 7). The Open MPI community regularly tests Open MPI (including PRTE) with GCC 4.8.1, so we know that works, too. Hence, abort configure if GCC is used and GCC is < v4.8.1. Signed-off-by: Jeff Squyres <[email protected]>
Member
Author
|
See the corresponding PMIx and PRTE PRs, too openpmix/openpmix#2294 and openpmix/prrte#1091. Also see the announcement on the Open MPI devel https://www.mail-archive.com/[email protected]/msg21314.html and packagers lists https://www.mail-archive.com/[email protected]/msg00063.html. |
Member
Author
|
@bwbarrett Well that's fun -- clang10 failed: Any idea why clang10 reported GNU 4.2.1? |
Member
|
It looks like opal_portable_platform.h was never updated to include clang. Looking at the code more, I don't think that we should be using the results of any of the OPAL_CHECK_COMPILER_VERSION_ID results unless we're going to start updating opal_portable_platform.h on a more regular basis. |
Member
Author
|
Ok. Should I attempt to parse the gcc version number, then? That kinda sucks, but it should be workable via regexp, perhaps something like (perl-like notation): |
Member
|
Can we instead either (1) just document the limitation or (2) test for whatever feature is causing the PMIX compile to fail? Looking at this more, trying to sanely get the GCC version without picking up leftovers from Intel or Clang is going to be really difficult. |
jsquyres
force-pushed
the
pr/compiler-updates-and-misc-updates
branch
from
65fcf57 to
b992423
Compare
We haven't supported AIX in years. Signed-off-by: Jeff Squyres <[email protected]>
NOTE: The default GCC that ships in RHEL is v4.8.5. Cisco regularly tests GCC v4.8.1, and it works fine. We know that PRTE and PMIX do not compile with RHEL 6's default GCC (v4.4.7). We know that v4.8.x works and 4.4.7 doesn't, so set the lower bound support for 4.8.1. Specifically: abort configure if the compiler is GCC and the version is < v4.8.1. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/compiler-updates-and-misc-updates
branch
from
b992423 to
12cef1f
Compare
Member
Author
|
Rebased on top of the merged update to the portable platform file (#9470). |
Member
Author
|
bot:ompi:retest |
|
The IBM CI (GNU/Scale) build failed! Please review the log, linked below. Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6 |
jsquyres
added a commit
to jsquyres/prrte
that referenced
this pull request
Oct 6, 2021
This is a port from the corresponding open-mpi/ompi#9398. PRTE does not compile with GCC 4.4.7 (the default GCC that ships in RHEL 6). PRTE *does* compile with GCC 4.8.5 (the default GCC that ships with RHEL 7). The Open MPI community regularly tests Open MPI (including PRTE) with GCC 4.8.1, so we know that works, too. Hence, abort configure if GCC is used and GCC is < v4.8.1. Signed-off-by: Jeff Squyres <[email protected]>
rhc54
pushed a commit
to rhc54/prrte
that referenced
this pull request
Oct 6, 2021
This is a port from the corresponding open-mpi/ompi#9398. PRTE does not compile with GCC 4.4.7 (the default GCC that ships in RHEL 6). PRTE *does* compile with GCC 4.8.5 (the default GCC that ships with RHEL 7). The Open MPI community regularly tests Open MPI (including PRTE) with GCC 4.8.1, so we know that works, too. Hence, abort configure if GCC is used and GCC is < v4.8.1. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 7975b6b)
rhc54
pushed a commit
to rhc54/openpmix
that referenced
this pull request
Oct 6, 2021
This is a port from the corresponding open-mpi/ompi#9398. OpenPMIx does not compile with GCC 4.4.7 (the default GCC that ships in RHEL 6). Open PMIx *does* compile with GCC 4.8.5 (the default GCC that ships with RHEL 7). The Open MPI community regularly tests Open MPI (including PMIx) with GCC 4.8.1, so we know that works, too. Hence, abort configure if GCC is used and GCC is < v4.8.1. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 33f35dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things:
These will need to be cherry-picked to v5.0.x.