UCX: Propagate MPI serialized for all worker creations #12608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 637b40e: UCX: Propagate MPI serialized for all worker creat...
df838c7: pml/ucx: Propagate MPI serialized thread mode
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
The UCX PML needs to differentiate between mpi serialized and single thread mode according to MPI standard. Using UCX with multiple threads, even when providing mutual exclusion, is not completely equivalent to only using UCX with one same thread. Signed-off-by: Thomas Vegas <[email protected]> (cherry picked from commit b33b61a)
Move MPI to UCX thread mode function to common source. Also use serialized mode for all oshmem initializations. Signed-off-by: Thomas Vegas <[email protected]> (cherry picked from commit efa293b)
tvegas1
force-pushed
the
ucx_thread_mode_combined_v5.0.x
branch
from
637b40e to
44cc663
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces first v5.0.x backport #12579
cherry-pick from main #12577 and #12590
What
The UCX PML needs to differentiate between mpi serialized and single thread mode according to MPI standard.
Why
Using UCX with multiple threads, even when providing mutual exclusion, is not completely equivalent to only using UCX with one same thread.
To guarantee ordering and avoid corruption, some UCX transports need the cpu to flush stores to the devices, before another thread can progress the worker. For latency reasons, this needed flush is only performed in non single thread mode.