-
Notifications
You must be signed in to change notification settings - Fork 936
UCX: Propagate MPI serialized for all worker creations #12590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
brminich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need to update spml_ucx_init in oshmem/mca/spml/ucx/spml_ucx_component.c
d257c2a to
305e8a4
Compare
It's already fixed as part of #12577, please let me know otherwise |
then why would we need to move it to common_ucx, if it used in pml only? |
Unfortunately, oshmem and ompi thread mode enums are different, so function cannot be reused. Also, the two oshmem thread mode checking functions are slightly different and cannot be merged. But moving to common file makes sense anyway I think, and I guess I'd reuse it for osc/ucx to be done in v4.1.x. |
|
do we need it for osc/ucx? |
osc/ucx change is needed in v4.1.x only |
305e8a4 to
9324c85
Compare
Move MPI to UCX thread mode function to common source. Also use serialized mode for all oshmem initializations. Signed-off-by: Thomas Vegas <[email protected]>
9324c85 to
efa293b
Compare
What
Continuation of #12577 by addressing comment from backport #12579.
Move MPI to UCX thread mode function to common source. Also use serialized mode for all oshmem initializations.
Test
Use: