Skip to content

Conversation

@tvegas1
Copy link
Contributor

@tvegas1 tvegas1 commented May 30, 2024

What

Continuation of #12577 by addressing comment from backport #12579.

Move MPI to UCX thread mode function to common source. Also use serialized mode for all oshmem initializations.

Test

Use:

shmem_ctx_t ctx;
shmem_ctx_create(0, &ctx);
shmem_ctx_create(SHMEM_CTX_SERIALIZED, &ctx);
shmem_ctx_create(SHMEM_CTX_PRIVATE, &ctx);

Copy link
Member

@brminich brminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to update spml_ucx_init in oshmem/mca/spml/ucx/spml_ucx_component.c

@tvegas1 tvegas1 force-pushed the ucx_thread_mode_common branch from d257c2a to 305e8a4 Compare May 30, 2024 12:22
@tvegas1
Copy link
Contributor Author

tvegas1 commented May 30, 2024

we also need to update spml_ucx_init in oshmem/mca/spml/ucx/spml_ucx_component.c

It's already fixed as part of #12577, please let me know otherwise

@brminich
Copy link
Member

we also need to update spml_ucx_init in oshmem/mca/spml/ucx/spml_ucx_component.c

It's already fixed as part of #12577, please let me know otherwise

then why would we need to move it to common_ucx, if it used in pml only?

@tvegas1
Copy link
Contributor Author

tvegas1 commented May 31, 2024

then why would we need to move it to common_ucx, if it used in pml only?

Unfortunately, oshmem and ompi thread mode enums are different, so function cannot be reused. Also, the two oshmem thread mode checking functions are slightly different and cannot be merged.

But moving to common file makes sense anyway I think, and I guess I'd reuse it for osc/ucx to be done in v4.1.x.

@tvegas1
Copy link
Contributor Author

tvegas1 commented Jun 3, 2024

@bosilca / @yosefe please check?

@yosefe
Copy link
Contributor

yosefe commented Jun 5, 2024

do we need it for osc/ucx?

@tvegas1
Copy link
Contributor Author

tvegas1 commented Jun 5, 2024

do we need it for osc/ucx?

osc/ucx change is needed in v4.1.x only

@tvegas1 tvegas1 force-pushed the ucx_thread_mode_common branch from 305e8a4 to 9324c85 Compare June 5, 2024 07:26
Move MPI to UCX thread mode function to common source. Also use
serialized mode for all oshmem initializations.

Signed-off-by: Thomas Vegas <[email protected]>
@tvegas1 tvegas1 force-pushed the ucx_thread_mode_common branch from 9324c85 to efa293b Compare June 6, 2024 16:30
@brminich brminich merged commit 2aef545 into open-mpi:main Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants