OSC/UCX: Properly releasing the resources and adding some debug info #11110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devreal
requested changes
Nov 23, 2022
MamziB
force-pushed
the
mamzi/osc-finalize-2
branch
2 times, most recently
from
6616534 to
eb42250
Compare
devreal
reviewed
Nov 23, 2022
Contributor
devreal
left a comment
devreal
left a comment
There was a problem hiding this comment.
Minor correction, otherwise looking good to me 👍
MamziB
force-pushed
the
mamzi/osc-finalize-2
branch
from
eb42250 to
97f4582
Compare
some debug info Signed-off-by: Mamzi Bayatpour <[email protected]> Co-authored-by: Tomislav Janjusic <[email protected]>
MamziB
force-pushed
the
mamzi/osc-finalize-2
branch
from
97f4582 to
19afd18
Compare
Contributor
Author
devreal
approved these changes
Nov 23, 2022
Contributor
|
@MamziB when you get a chance please open up v5.0 equivalent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSC/UCX: Properly releasing the resources and adding some debug info
Signed-off-by: Mamzi Bayatpour [email protected]
Co-authored-by: Tomislav Janjusic [email protected]
@janjust