Skip to content

Non-debug build with UCX (recently) broken #11114

@alex--m

Description

@alex--m

PR #11110 seems to have broken the non-debug build with UCX (for the main branch).
The error is as follows:

  CC       libopen-palmca_common_ucx_noinst_la-common_ucx_wpool.lo
In file included from common_ucx_wpool.c:4:
common_ucx_wpool.h:71:42: error: expected parameter name, found "&"
   71 | #define OPAL_COMMON_UCX_DEBUG_ATOMIC_ADD(&(_var), (_val));
      |                                          ^
common_ucx_wpool.c: In function '_winfo_destructor':
common_ucx_wpool.c:109:21: warning: implicit declaration of function 'OPAL_COMMON_UCX_DEBUG_ATOMIC_ADD' [-Wimplicit-function-declaration]
  109 |                     OPAL_COMMON_UCX_DEBUG_ATOMIC_ADD(opal_common_ucx_ep_counts, -1);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1651: libopen-palmca_common_ucx_noinst_la-common_ucx_wpool.lo] Error 1

I suggest it should just be:

#define OPAL_COMMON_UCX_DEBUG_ATOMIC_ADD(_var, _val)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions