Do not fetch cudart from gitlab for UMF #2680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ldorau
force-pushed
the
Set_UMF_CUDA_INCLUDE_DIR_to_not_fetch_cudart_from_gitlab
branch
2 times, most recently
from
6341dd2 to
95d6d84
Compare
ldorau
changed the title
ldorau
force-pushed
the
Set_UMF_CUDA_INCLUDE_DIR_to_not_fetch_cudart_from_gitlab
branch
from
95d6d84 to
dd32765
Compare
|
@bratpiorka @pbalcer please review |
|
FYI, this PR includes my changes from #2672 |
|
llvm: intel/llvm#16941 |
bratpiorka
approved these changes
Feb 10, 2025
pbalcer
approved these changes
Feb 10, 2025
ldorau
force-pushed
the
Set_UMF_CUDA_INCLUDE_DIR_to_not_fetch_cudart_from_gitlab
branch
from
dd32765 to
ea22cde
Compare
ldorau
force-pushed
the
Set_UMF_CUDA_INCLUDE_DIR_to_not_fetch_cudart_from_gitlab
branch
from
ea22cde to
4dc82ef
Compare
|
Can we get this merged? Thanks! @kbenzie |
|
@oneapi-src/unified-runtime-cuda-write please review |
Set UMF_CUDA_INCLUDE_DIR so that UMF does not fetch cudart from gitlab.com. Signed-off-by: Lukasz Dorau <[email protected]>
Update UMF to commit ace9f4a60b686463fdad15cd016c548237cb79e0: Date: Mon Feb 10 11:39:15 2025 +0100 Merge pull request oneapi-src#1088 from ldorau/Fix_remove_CUDA_ERROR_INVALID_RESOURCE_TYPE Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Set_UMF_CUDA_INCLUDE_DIR_to_not_fetch_cudart_from_gitlab
branch
from
4dc82ef to
84454b0
Compare
|
Rebased and merge conflict resolved. Nothing more changed. |
frasercrmck
approved these changes
Feb 12, 2025
ldorau
deleted the
Set_UMF_CUDA_INCLUDE_DIR_to_not_fetch_cudart_from_gitlab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
UMF_CUDA_INCLUDE_DIRso that UMF does not fetch cudart from gitlab.com.llvm: intel/llvm#16941