Skip to content

[HIP] Ifdef entry point introduced in HIP 5.6 #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2023
Merged

[HIP] Ifdef entry point introduced in HIP 5.6 #1088

merged 5 commits into from
Nov 28, 2023

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Nov 16, 2023

hipArray3DGetDescriptor was introduced in HIP 5.6

@hdelan hdelan requested a review from a team as a code owner November 16, 2023 17:04
alexbatashev
alexbatashev reviewed Nov 17, 2023
View reviewed changes
@hdelan hdelan closed this Nov 20, 2023
@hdelan hdelan reopened this Nov 20, 2023
@hdelan hdelan mentioned this pull request Nov 21, 2023
Closed
@hdelan
Copy link
Contributor Author

hdelan commented Nov 21, 2023

intel/llvm#11963

al42and
al42and reviewed Nov 27, 2023
View reviewed changes
al42and
al42and reviewed Nov 27, 2023
View reviewed changes
@al42and
Copy link
Contributor

al42and commented Nov 27, 2023 •
edited
Loading

Shall we also skip urMemGetInfoImageTest.Success test, or is it better if it fails?

Edit: and also urMemImageGetInfoTest.* tests?

@hdelan
Copy link
Contributor Author

hdelan commented Nov 27, 2023

We have a fail list here https://github.com/oneapi-src/unified-runtime/blob/adapters/test/conformance/memory/memory_adapter_hip.match so it should be fine already since tests bail with Segmentation Fault before MemImage tests

@kbenzie
Copy link
Contributor

kbenzie commented Nov 28, 2023

I'm going to include this in intel/llvm#12004 since it addresses a compile error and should be merged ASAP.

@kbenzie kbenzie merged commit 5e914c5 into oneapi-src:adapters Nov 28, 2023
@kbenzie kbenzie mentioned this pull request Nov 28, 2023
Merged
kbenzie added a commit that referenced this pull request Nov 28, 2023
@kbenzie
Merge pull request #1088 from hdelan/ifdef-hip-5.6
fb1ce0c 
[HIP] Ifdef entry point introduced in HIP 5.6
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Nov 29, 2023
@kbenzie
[UR] Bump tag to 41228d3
af70445 
Combines the follow UR changes:

* oneapi-src/unified-runtime#1037
* oneapi-src/unified-runtime#1097
* oneapi-src/unified-runtime#1106
* oneapi-src/unified-runtime#1039
* oneapi-src/unified-runtime#993
* oneapi-src/unified-runtime#1088

Depends on intel#11893 merging first.
steffenlarsen pushed a commit to intel/llvm that referenced this pull request Nov 29, 2023
@kbenzie
[UR] Bump tag to v0.8.1 (#12004)
ef6f8f4 
Combines the follow UR changes:

* oneapi-src/unified-runtime#1037
* oneapi-src/unified-runtime#1097
* oneapi-src/unified-runtime#1106
* oneapi-src/unified-runtime#1039
* oneapi-src/unified-runtime#1088

Depends on #11893 merging first.
callumfare pushed a commit to kbenzie/intel-llvm that referenced this pull request Dec 18, 2023
@kbenzie @callumfare
[UR] Bump tag to v0.8.1 (intel#12004)
bf888f9 
Combines the follow UR changes:

* oneapi-src/unified-runtime#1037
* oneapi-src/unified-runtime#1097
* oneapi-src/unified-runtime#1106
* oneapi-src/unified-runtime#1039
* oneapi-src/unified-runtime#1088

Depends on intel#11893 merging first.
ldorau added a commit to ldorau/unified-runtime that referenced this pull request Feb 10, 2025
@ldorau
Update UMF
dd32765 
Update UMF to commit ace9f4a60b686463fdad15cd016c548237cb79e0:
Date: Mon Feb 10 11:39:15 2025 +0100
Merge pull request oneapi-src#1088 from ldorau/Fix_remove_CUDA_ERROR_INVALID_RESOURCE_TYPE

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-runtime that referenced this pull request Feb 10, 2025
@ldorau
Update UMF
b0373f4 
Update UMF to commit ace9f4a60b686463fdad15cd016c548237cb79e0:
Date: Mon Feb 10 11:39:15 2025 +0100
Merge pull request oneapi-src#1088 from ldorau/Fix_remove_CUDA_ERROR_INVALID_RESOURCE_TYPE

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-runtime that referenced this pull request Feb 10, 2025
@ldorau
Update UMF
4658e93 
Update UMF to commit ace9f4a60b686463fdad15cd016c548237cb79e0:
Date: Mon Feb 10 11:39:15 2025 +0100
Merge pull request oneapi-src#1088 from ldorau/Fix_remove_CUDA_ERROR_INVALID_RESOURCE_TYPE

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-runtime that referenced this pull request Feb 10, 2025
@ldorau
Update UMF
ea22cde 
Update UMF to commit ace9f4a60b686463fdad15cd016c548237cb79e0:
Date: Mon Feb 10 11:39:15 2025 +0100
Merge pull request oneapi-src#1088 from ldorau/Fix_remove_CUDA_ERROR_INVALID_RESOURCE_TYPE

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-runtime that referenced this pull request Feb 10, 2025
@ldorau
Update UMF
4dc82ef 
Update UMF to commit ace9f4a60b686463fdad15cd016c548237cb79e0:
Date: Mon Feb 10 11:39:15 2025 +0100
Merge pull request oneapi-src#1088 from ldorau/Fix_remove_CUDA_ERROR_INVALID_RESOURCE_TYPE

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-runtime that referenced this pull request Feb 10, 2025
@ldorau
Update UMF
4b5799a 
Update UMF to commit ace9f4a60b686463fdad15cd016c548237cb79e0:
Date: Mon Feb 10 11:39:15 2025 +0100
Merge pull request oneapi-src#1088 from ldorau/Fix_remove_CUDA_ERROR_INVALID_RESOURCE_TYPE

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-runtime that referenced this pull request Feb 12, 2025
@ldorau
Update UMF
84454b0 
Update UMF to commit ace9f4a60b686463fdad15cd016c548237cb79e0:
Date: Mon Feb 10 11:39:15 2025 +0100
Merge pull request oneapi-src#1088 from ldorau/Fix_remove_CUDA_ERROR_INVALID_RESOURCE_TYPE

Signed-off-by: Lukasz Dorau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@JackAKirk JackAKirk JackAKirk approved these changes

+2 more reviewers

@alexbatashev alexbatashev alexbatashev left review comments

@al42and al42and al42and approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hdelan @al42and @kbenzie @alexbatashev @JackAKirk