Skip to content

[UMF] bump UMF version to v0.10.0 and adjust code #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

[UMF] bump UMF version to v0.10.0 and adjust code #2436

merged 1 commit into from
Dec 11, 2024
+184 −80

Conversation

@igchor
Copy link
Contributor

@igchor igchor commented Dec 6, 2024 •
edited
Loading

to the new params API

Testing PR to llvm: intel/llvm#16322

@github-actions github-actions bot added common Changes or additions to common utilities level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues labels Dec 6, 2024
This was referenced Dec 6, 2024
Closed
Closed
@lukaszstolarczuk lukaszstolarczuk added the v0.11.x Include in the v0.11.x release label Dec 9, 2024
@kbenzie
Copy link
Contributor

kbenzie commented Dec 9, 2024

Should this be made ready for review @igchor?

@lukaszstolarczuk
Copy link
Contributor

lukaszstolarczuk commented Dec 9, 2024

Should this be made ready for review @igchor?

I'm doing a UMF release tag 0.10.0 in just a moment, then it could be used and this PR could be ready, I believe

vinser52
vinser52 reviewed Dec 9, 2024
View reviewed changes
@igchor igchor force-pushed the umf_params_bump branch 2 times, most recently from f8b156c to d27d50f Compare December 9, 2024 17:01
@igchor
Copy link
Contributor Author

igchor commented Dec 9, 2024

Should this be made ready for review @igchor?

I'm doing a UMF release tag 0.10.0 in just a moment, then it could be used and this PR could be ready, I believe

Done.

@igchor igchor marked this pull request as ready for review December 9, 2024 17:01
@igchor igchor requested review from a team as code owners December 9, 2024 17:01
@igchor igchor requested a review from omarahmed1111 December 9, 2024 17:01
ldrumm
ldrumm suggested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@ldrumm ldrumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • s/UFM/UMF/ in the commit message and merge request title
  • I know the naming conventions are a bit all over the place, but please try and match the surrounding code as you've done in the level zero adapter
  • Please also put the 0.1 version in the commit message so users can see it at a glance

@igchor
Copy link
Contributor Author

igchor commented Dec 9, 2024

  • s/UFM/UMF/ in the commit message and merge request title
  • I know the naming conventions are a bit all over the place, but please try and match the surrounding code as you've done in the level zero adapter
  • Please also put the 0.1 version in the commit message so users can see it at a glance

Done. I changed the naming so that all variables' names are uppercase, please let me know if I missed something else.

@igchor igchor changed the title [UMF] bump UFM version and adjust code [UMF] bump UMF version to v0.10.0 and adjust code Dec 9, 2024
ldrumm
ldrumm approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@ldrumm ldrumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/UFM/UMF/ in the commit and merge request title

  • s/UFM/UMF/ in the commit message and merge request title
  • I know the naming conventions are a bit all over the place, but please try and match the surrounding code as you've done in the level zero adapter
  • Please also put the 0.1 version in the commit message so users can see it at a glance

Done. I changed the naming so that all variables' names are uppercase, please let me know if I missed something else.

Looks good. Thanks

lukaszstolarczuk
lukaszstolarczuk reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx Igor!

LGTM 👍

@igchor
Copy link
Contributor Author

igchor commented Dec 10, 2024

@nrspruit could you please take a look at the L0 changes?

@pbalcer pbalcer added the ready to merge Added to PR's which are ready to merge label Dec 11, 2024
@igchor igchor mentioned this pull request Dec 11, 2024
Merged
@martygrant martygrant merged commit 58e4d76 into oneapi-src:main Dec 11, 2024
73 checks passed
@martygrant martygrant mentioned this pull request Dec 11, 2024
Merged
igchor added a commit to igchor/llvm that referenced this pull request Dec 11, 2024
@igchor
[UR] Update tag to 58e4d76 for:
ec46e32 
- oneapi-src/unified-runtime#2436
- oneapi-src/unified-runtime#2434
@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk left review comments

@PatKamin PatKamin PatKamin left review comments

@vinser52 vinser52 vinser52 approved these changes

@pbalcer pbalcer pbalcer approved these changes

@omarahmed1111 omarahmed1111 Awaiting requested review from omarahmed1111 omarahmed1111 was automatically assigned from oneapi-src/unified-runtime-hip-write

+1 more reviewer

@ldrumm ldrumm ldrumm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

common Changes or additions to common utilities cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge v0.11.x Include in the v0.11.x release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@igchor @kbenzie @lukaszstolarczuk @ldrumm @vinser52 @pbalcer @PatKamin @martygrant