[CMake] Add UR_USE_EXTERNAL_UMF to find pre-built UMF #2434
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, by configuring with `-Dumf_ROOT=/path/to/umf-install`.
Contributor
|
@tcreech-intel, should this still be a draft? I believe you've tested this change with UMF's latest package @kbenzie, ping, perhaps this should be included in v0.11.x ...? |
Contributor
Yes. |
Contributor
Author
It can be considered ready. I've tested with our latest internal drop and also with a locally built/installed UMF. |
pbalcer
approved these changes
Dec 11, 2024
igchor
added a commit
to igchor/llvm
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, by configuring with
-Dumf_ROOT=/path/to/umf-install.