[HIP][CUDA] Refactor using profiling events #1634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cuda
hdelan
reviewed
May 22, 2024
hdelan
reviewed
May 22, 2024
source/adapters/hip/queue.hpp
Outdated
| // Stream used solely when profiling is enabled | ||
| native_type ProfStream; | ||
| bool IsProfStreamCreated{false}; | ||
| std::once_flag ProfStreamFlag; |
There was a problem hiding this comment.
Do we need to keep this in the queue struct? Or could we have it local to createProfilingStream?
There was a problem hiding this comment.
For some reason, having static std::once_flag local to createProfilingStream was breaking some tests, not sure why...
There was a problem hiding this comment.
For some reason, having
static std::once_flaglocal tocreateProfilingStreamwas breaking some tests, not sure why...
Looks like this worked now.
|
Also I wouldn't mind if |
keyradical
force-pushed
the
RefactorHIPBaseEvent
branch
2 times, most recently
from
178dc5e to
d0cc077
Compare
hdelan
reviewed
May 23, 2024
hdelan
reviewed
May 23, 2024
keyradical
force-pushed
the
RefactorHIPBaseEvent
branch
from
ffc00a1 to
d082057
Compare
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Jun 7, 2024
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Jun 10, 2024
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Jun 24, 2024
oneapi-src/unified-runtime#1634 is believed to have fixed the issues for HIP in the profiling tag extension. This commit reenables the tests for HIP. Closes intel#12904. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIP changes:
EvBasein HIP was moved todeviceandgetElapsedTimefunction now handles the profiling events' synchronization. Also, we were usinghipStreamDefaultflag as default, but in CUDA, we useCU_STREAM_NON_BLOCKING, this was also changed to match with cuda, commits 1-3Queuewhich is only created when profiling is enabled and it is used to recordEvQueued. This was necessary because before we were recording it on theNULLstream and this might not be the best solution for HIP, see HIP profiling submission time query returns weird values intel/llvm#12904, commit 4CUDA changes:
intel/llvm CI: intel/llvm#13861