Skip to content

[CUDA][HIP] Fix return type of various device attributes. #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2024
Merged

[CUDA][HIP] Fix return type of various device attributes. #1568

merged 2 commits into from
Jun 5, 2024

Conversation

mmoadeli
Copy link
Contributor

@mmoadeli mmoadeli commented May 1, 2024

Modified return types of the following device attributes for CUDA and HIP backends to ensure compliance with specification

  • UR_DEVICE_INFO_IMAGE_MAX_ARRAY_SIZE
  • UR_DEVICE_INFO_MAX_PARAMETER_SIZE
  • UR_DEVICE_INFO_PROFILING_TIMER_RESOLUTION
  • UR_DEVICE_INFO_PRINTF_BUFFER_SIZE

There were failures on testing test-e2e/Basic/info.cpp on Windows due to use of invalid types.

@mmoadeli mmoadeli requested review from a team as code owners May 1, 2024 17:59
@mmoadeli mmoadeli requested a review from ldrumm May 1, 2024 17:59
@github-actions github-actions bot added cuda CUDA adapter specific issues hip HIP adapter specific issues labels May 1, 2024
@mmoadeli mmoadeli added hip HIP adapter specific issues and removed hip HIP adapter specific issues labels May 1, 2024
@mmoadeli mmoadeli force-pushed the fix-ur-return-type branch from e6308df to 2c8d688 Compare May 1, 2024 17:59
ldrumm
ldrumm approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@ldrumm ldrumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took me so long to review. This looks like good cleanup.

@mmoadeli
Copy link
Contributor Author

@kbenzie a friendly request to have this PR merged, if it looks fine to you.

@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label May 29, 2024
@kbenzie
Copy link
Contributor

kbenzie commented May 29, 2024

@kbenzie a friendly request to have this PR merged, if it looks fine to you.

It has been added to the merge queue.

@kbenzie kbenzie merged commit 8d86f5b into oneapi-src:main Jun 5, 2024
@kbenzie kbenzie mentioned this pull request Jun 5, 2024
Merged
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Jun 7, 2024
@kbenzie
[UR] Bump main tag to f06bc02
b105a38 
Includes the following:

* oneapi-src/unified-runtime#1653
* oneapi-src/unified-runtime#1568
* oneapi-src/unified-runtime#1634
* oneapi-src/unified-runtime#1669
martygrant pushed a commit to intel/llvm that referenced this pull request Jun 10, 2024
@kbenzie
[UR] Bump main tag to f06bc02 (#14047)
fcfe36b 
Includes the following:

* oneapi-src/unified-runtime#1653
* oneapi-src/unified-runtime#1568
* oneapi-src/unified-runtime#1634
* oneapi-src/unified-runtime#1669
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
@kbenzie @ianayl
[UR] Bump main tag to f06bc02 (intel#14047)
52111a7 
Includes the following:

* oneapi-src/unified-runtime#1653
* oneapi-src/unified-runtime#1568
* oneapi-src/unified-runtime#1634
* oneapi-src/unified-runtime#1669
@mmoadeli mmoadeli deleted the fix-ur-return-type branch June 19, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@ldrumm ldrumm ldrumm approved these changes

Assignees
No one assigned
Labels
cuda CUDA adapter specific issues hip HIP adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmoadeli @kbenzie @ldrumm