Skip to content

MODIN: fix getting started samples testing in CI #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2022
Merged

MODIN: fix getting started samples testing in CI #863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ae6ea4
MODIN: fix samples testing in CI
dchigarev Feb 13, 2022
8f21ecf
Try to combine env setup steps into a single cell
dchigarev Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions AI-and-Analytics/Getting-Started-Samples/IntelModin_GettingStarted/sample.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,17 @@
"ciTests": {
"linux": [
{
"env": ["source /opt/intel/oneapi/setvars.sh --force", "conda create -n aikit-modin-test -c intel -c conda-forge matplotlib runipy intel-aikit-modin", "source activate aikit-modin-test"],
"env": [],
Copy link
Contributor Author

@dchigarev dchigarev Feb 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, placing environment setup and the notebook execution in different cells (env and steps) caused the environment wasn't applied (this was indicated by the "Import error: couldn't find 'modin'" error at CI logs).

Combining environment setup steps and the actual notebook execution in a single cell resolved the problem.

"id": "Intel_Modin_GS_py",
"steps": [
"runipy IntelModin_GettingStarted.ipynb"
]
"set -e # Terminate the script on first error",
"source $(conda info --base)/etc/profile.d/conda.sh # Bypassing conda's disability to activate environments inside a bash script: https://github.com/conda/conda/issues/7980",
"conda create -y -n intel-aikit-modin intel-aikit-modin -c intel",
"conda activate intel-aikit-modin",
"pip install -r requirements.txt # Installing notebook's dependencies",
"pip install runipy # Installing 'runipy' for extended abilities to execute the notebook",
"runipy IntelModin_GettingStarted.ipynb"
]
}
]
}
Expand Down