Skip to content

Conversation

dchigarev
Copy link
Contributor

Signed-off-by: Dmitry Chigarev [email protected]

Existing Sample Changes

Description

This PR is supposed to fix failing CI testing for Modin's getting started samples. The CI flow has been failing due to conda's failures during environment initialization inside the bash script (conda/conda#7980). The CI script was modified as follows to resolve the problem:

  1. Source conda.sh before using conda to be able to activate environments inside a bash script (Can't execute conda activate from bash script conda/conda#7980).
  2. Use set -e at the beginning of the CI script to ease debugging if something goes wrong.
  3. Install notebook's dependencies from requirements.txt rather than manually listing them.

Fixes Jira REIE-1371.

External Dependencies

No external dependencies were added.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Command Line

To test the changes locally:

  1. Combine steps from the sample.json into a single bash script.
  2. Run the script and ensure that the last notebook's cell printed"[CODE_SAMPLE_COMPLETED_SUCCESFULLY]"

praveenkk123
praveenkk123 previously approved these changes Feb 14, 2022
Copy link
Contributor

@praveenkk123 praveenkk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI

@dchigarev
Copy link
Contributor Author

For some reason, the CI container still can't import modin package during the notebook's flow. I guess this is because activating conda environment and the notebook execution were split into different cells (env and steps in sample.json). I've combined them together to see if it helps, @praveenkk123 could you rerun CI, please?

Copy link
Contributor

@praveenkk123 praveenkk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI

@@ -10,11 +10,17 @@
"ciTests": {
"linux": [
{
"env": ["source /opt/intel/oneapi/setvars.sh --force", "conda create -n aikit-modin-test -c intel -c conda-forge matplotlib runipy intel-aikit-modin", "source activate aikit-modin-test"],
"env": [],
Copy link
Contributor Author

@dchigarev dchigarev Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, placing environment setup and the notebook execution in different cells (env and steps) caused the environment wasn't applied (this was indicated by the "Import error: couldn't find 'modin'" error at CI logs).

Combining environment setup steps and the actual notebook execution in a single cell resolved the problem.

@dchigarev
Copy link
Contributor Author

@praveenkk123 thanks for rerunning! CI is green now

@praveenkk123 praveenkk123 merged commit 5a8c6e4 into oneapi-src:master Feb 16, 2022
@dchigarev dchigarev mentioned this pull request Feb 17, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants