-
Notifications
You must be signed in to change notification settings - Fork 727
MODIN: fix getting started samples testing in CI #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dmitry Chigarev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for CI
Signed-off-by: Dmitry Chigarev <[email protected]>
For some reason, the CI container still can't import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for CI
@@ -10,11 +10,17 @@ | |||
"ciTests": { | |||
"linux": [ | |||
{ | |||
"env": ["source /opt/intel/oneapi/setvars.sh --force", "conda create -n aikit-modin-test -c intel -c conda-forge matplotlib runipy intel-aikit-modin", "source activate aikit-modin-test"], | |||
"env": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, placing environment setup and the notebook execution in different cells (env
and steps
) caused the environment wasn't applied (this was indicated by the "Import error: couldn't find 'modin'" error at CI logs).
Combining environment setup steps and the actual notebook execution in a single cell resolved the problem.
@praveenkk123 thanks for rerunning! CI is green now |
Signed-off-by: Dmitry Chigarev [email protected]
Existing Sample Changes
Description
This PR is supposed to fix failing CI testing for Modin's getting started samples. The CI flow has been failing due to conda's failures during environment initialization inside the bash script (conda/conda#7980). The CI script was modified as follows to resolve the problem:
conda.sh
before using conda to be able to activate environments inside a bash script (Can't executeconda activate
from bash script conda/conda#7980).set -e
at the beginning of the CI script to ease debugging if something goes wrong.requirements.txt
rather than manually listing them.Fixes Jira REIE-1371.
External Dependencies
No external dependencies were added.
Type of change
How Has This Been Tested?
To test the changes locally:
sample.json
into a single bash script.